Extend README #21
Extend README #21
Conversation
sgasse
commented
Aug 9, 2020
sgasse
commented
- Add loading of http_archive rule.
- Explicilty mention to replace commit hashes.
|
This removes a necessary detail when dealing with release tags instead of commit hashes. For example, take the latest release from the pybind repository (v2.5.0):
Naming the placeholder Perhaps a better approach would be to use a a generic name for the placeholder (e.g. Note that this distinction isn't necessary for this repository. Since there are no tagged releases (for now at least), commit hashes are the only option. Hence the placeholder being named |
- Add loading of http_archive rule. - Explicilty mention to replace version identifiers.
|
Ah thank you for explaining the difference, @chuckx ! I updated my changes accordingly. Would it make sense like this? |
| ) | ||
| load("@pybind11_bazel//:python_configure.bzl", "python_configure") | ||
| python_configure(name = "local_config_python") | ||
| ``` | ||
|
|
||
| Replace `<version-identifier>` with the version you want to use. | ||
| - For `pybind11_bazel`, there are no tagged releases yet, so `<version-identifier>` has to be replaced with a full commit hash. | ||
| - For `pybind11`, you can either use a commit hash or a release tag like `v2.5.0`. |
There was a problem hiding this comment.
This still glosses over the distinction necessary for the strip_prefix value (2.5.0) vs. the urls value (v2.5.0).
