New Notebooks (masses_and_volumes, capacities_and_potentials and ragone), documentation, testing #23
+3,659
−1,451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtimms
requested changes
Nov 9, 2023
examples/stack_breakdown.py
Outdated
| import pybamm | ||
| from pybamm_tea import tea |
There was a problem hiding this comment.
does this work? you shouldn't be able to import tea (it's not a method anywhere).
examples/stack_breakdown.py
Outdated
| base = pybamm.ParameterValues("Chen2020") | ||
|
|
||
| # create a TEA class | ||
| tea_class = tea.TEA(base, input) |
examples/stack_breakdown.py
Outdated
| # electrode stack | ||
| print(tea_nco.stack_breakdown_dataframe) | ||
| # get the mass and volume loadings as a dataframe | ||
| tea_class.masses_and_volumes_dataframe |
There was a problem hiding this comment.
why not print this anymore?
tests/test_tea.py
Outdated
| @@ -1,55 +1,121 @@ | |||
| import unittest | |||
| import pybamm | |||
| from pybamm_tea import TEA | |||
| from pybamm_tea import tea | |||
There was a problem hiding this comment.
does this work? I don't get why how you import things has changed in this PR?
| "# create vectors of stoichiometries\n", | ||
| "soc = pybamm.linspace(0, 1)\n", | ||
| "x = x0 + (x100 - x0) * soc\n", | ||
| "y = y100 + (y0 - y100) * soc\n", |
There was a problem hiding this comment.
check how you've defined this. right now at soc=1 you have that y = y0, not y100. I think it should be
x = x_0 + soc * (x_100 - x_0)
y = y_0 - soc * (y_0 - y_100)
but also check how you have defined x_0, x_100, y_0, y_100. these should be defined wrt to cell level SOC
| "input_lithium_discharged = {\n", | ||
| "\n", | ||
| " # initialize the concentration in the negative electrode\n", | ||
| " \"Initial concentration in negative electrode [mol.m-3]\": None,\n", |
There was a problem hiding this comment.
can you explain what happens/why you have set these to None
|
@julian-evers are these changes also in #25 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.