Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalised symbol copying #4023

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Generalised symbol copying #4023

wants to merge 16 commits into from

Commits on May 9, 2024

  1. Edit create_copy to accept new children

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    99e9cb3 View commit details
    Browse the repository at this point in the history

  2. Condense _process_symbol

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    da34e36 View commit details
    Browse the repository at this point in the history

  3. Add test for copying with new children

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7d48a1c View commit details
    Browse the repository at this point in the history

  4. Increase coverage for create_copy

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a8204e3 View commit details
    Browse the repository at this point in the history

  5. Add errors for number of children provided to create_copy 

    Abstract out checks for if new children are provided
Improve _unary_new_copy doc strings
    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b19c45a View commit details
    Browse the repository at this point in the history

  6. Adds 'perform_simplifications' to create_copy() to allow user choice

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    54623bc View commit details
    Browse the repository at this point in the history

  7. Update _unary_ and _concatenation_new_copy to take perform_simplifica… 

    …tion

Allows for classes with different input parameters to be called without re-defining the whole create_copy function (with unary errors) each time
    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9d7846b View commit details
    Browse the repository at this point in the history

  8. change _process_symbol() to use create_copy() not _binary_create_copy().

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f9cd000 View commit details
    Browse the repository at this point in the history

  9. Add more tests

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d221195 View commit details
    Browse the repository at this point in the history

  10. Add function_new_copy test

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bc00b0c View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into symbol-copy

    @pipliggins
    pipliggins committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bf9cbee View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Deprecate symbol.new_copy() in favour of symbol.create_copy() 

    Avoids confusion with model.new_copy()
    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1a60913 View commit details
    Browse the repository at this point in the history

  2. Add test copying entire discretised DFN rhs tree

    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    182233e View commit details
    Browse the repository at this point in the history

  3. edit averages create_copy tests

    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4988be9 View commit details
    Browse the repository at this point in the history

  4. Update to use create_copy() rather than private copy functions where … 

    …possible
    @pipliggins
    pipliggins committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8b9de85 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'develop' into symbol-copy

    @martinjrobins
    martinjrobins committed May 16, 2024
    Configuration menu
    Copy the full SHA
    32af2c9 View commit details
    Browse the repository at this point in the history