-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Arg pybamm.Experiment.period #3986
update Arg pybamm.Experiment.period #3986
Conversation
this is part of the preparation for the April PyBamm training. |
863da32
to
c6801f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3986 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21254 21254
========================================
Hits 21166 21166
Misses 88 88 ☔ View full report in Codecov by Sentry. |
c6801f6
to
9369bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AndyLiuElysia!
@all-contributors add @AndyLiuElysia for docs |
I've put up a pull request to add @AndyLiuElysia! 🎉 |
Description
The Arg in pybam.experiment has been updated.
This is one of the issue listed in #3392
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: