Refactor test_experiment_step_termination.py*** #3800
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(from unittest to pytest)
|
Thanks for starting this @abhicodes369. It looks good, but ideally we want to do this after #3617, so I will let this sit for a while until that is complete and |
|
@abhicodes369, if you're interested, you can help drive #3857 to completion – or we can take this up again after it gets merged (should be about a week at most). |
|
I will look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(from unit test to pytest)
Description
converted a unit test case that uses the unit test to pytest. On the official website of pybamm I saw that they are considering migrating from unit test to pytest.