Remove old JAX restrictions for Winows and test cleanup #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be rebased/forced pushed after #3932 is merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3942 +/- ##
===========================================
- Coverage 99.60% 99.58% -0.03%
===========================================
Files 259 257 -2
Lines 21347 21190 -157
===========================================
- Hits 21263 21102 -161
- Misses 84 88 +4 ☔ View full report in Codecov by Sentry. |
kratman
changed the title
kratman
force-pushed
the
feat/jaxWindows
branch
from
47feff2
to
4bf5a3a
Compare
|
I broke this branch when I rebased. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for JAX on windows was improved. This change removes the nox file restrictions on JAX. This builds on #3932 and keeps that one focused on just ODES.
Fixes #3941
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: