Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is likely a safer way to trap #133

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

this is likely a safer way to trap #133

wants to merge 2 commits into from

Conversation

ZeroChaos-
Copy link
Contributor

This should solve the reported issue but it NEEDS TESTED
#132

When we dropped trapping of sigint and sigterm it did not occur to me that trapping quit would only work for if the shell is quit, not the script. Meaning according to the report ". ./evilap.sh" will trap properly on ^C but "./evilap.sh" won't. I have not tested the reported issue, nor have I tested the fix. But we removed the trap because it was double running cleanup and this prevents that.

@AnipTiK
Copy link

AnipTiK commented Nov 13, 2016

What is the difference between ". ./evilap.sh" & "./evilap.sh"?
I launch EvilAP from the icon, it launches the script with the second method.

@ZeroChaos-
Copy link
Contributor Author

Odd, I had assume you were manually running via the cli since on my end it
does clean up properly when run from the icon. Either way, please feel free
to test the linked PR in any way you see fit and report back. Please pay
careful attention that cleanup is run only once.

On Nov 13, 2016 17:05, "AnipTiK" notifications@github.com wrote:

What is the difference between ". ./evilap.sh" & "./evilap.sh"?
I launch EvilAP from the icon, it launches the script with the second
method.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#133 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABl--fu81_Lr-0BCx17zqVxHypdrQcOAks5q94m-gaJpZM4KwxiZ
.

This e-mail and any attachments are for the sole use of the intended
recipients(s) and may be confidential. Use of any Pwnie Express product
signifies your agreement to the Rapid Focus Security Terms of Service
https://www.pwnieexpress.com/terms-of-service and is subject to export
controls under the U.S. Commerce Department’s Export Administration
Regulations (“EAR”).

@AnipTiK
Copy link

AnipTiK commented Nov 15, 2016

I tried your modified version of EvilAP and the modified version from here. They aren't working, here is the log. (same for both)
screenshot_2016-11-15-22-10-38

@ZeroChaos-
Copy link
Contributor Author

Corrupted whitespace somehow when you downloaded. You have windows line
endings.

On Nov 15, 2016 17:11, "AnipTiK" notifications@github.com wrote:

I tried your modified version of EvilAP and the modified version from here
https://github.com/pwnieexpress/pwn_pad_sources/blob/9960dc6dcddb59e767c70df23c403cd6dc58e6e3/scripts/evilap.sh.
They aren't working, here is the log. (some for both)
[image: screenshot_2016-11-15-22-10-38]
https://cloud.githubusercontent.com/assets/23408993/20326385/ccfbe31e-ab88-11e6-8c21-bfb36a367848.png


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#133 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABl--So8ShNLI1TnrVnbHdsETAxTn7PXks5q-i4ggaJpZM4KwxiZ
.

This e-mail and any attachments are for the sole use of the intended
recipients(s) and may be confidential. Use of any Pwnie Express product
signifies your agreement to the Rapid Focus Security Terms of Service
https://www.pwnieexpress.com/terms-of-service and is subject to export
controls under the U.S. Commerce Department’s Export Administration
Regulations (“EAR”).

@AnipTiK
Copy link

AnipTiK commented Nov 15, 2016

Ok, removed it.
Still is an issue
tail: invalid pid (added evil_ap_cui after?)

Fixed it replacing
tail -n +0 --pid=${hostapd_wpe_pid} -f "$logname"
With
if [ -n "${hostapd_wpe_pid}" ]; then # start the evil api UI /opt/pwnix/pwnpad-scripts/evil_ap_cui.rb ${evil_cui_karma} -l "${logname}" -s "${ssid}" -c "${channel}" elif [ -n "${airbase_ng_pid}" ]; then tail -n +0 --pid=${airbase_ng_pid} -f "$logname" fi

Ctrl C is working. (I used here the other modified file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants