Generic setting for allowing password reset on REQUIRE_NEW_PWD error #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t change password is set
…ey are superseded by new generic setting
|
Given the ldapchai PR was merged, any idea when this could be considered for approval? |
|
@jrivard Brought this branch in line with master; please let me know if there's anything else you'd like to see before this could be merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduce a new required setting,
ldap.allowAuth.requireNewPassword, replacing the functionality ofldap.ad.allowAuth.requireNewPasswordandldap.oracleDS.allowAuth.requireNewPassword. Usage of the latter two settings has been substituted for the former, allowing deprecation of those vendor-specific settings.This allows for deduplicating code in
LDAPAuthenticationRequest.java, with the initial benefit being somewhat reduced complexity, and the additional benefit of allowing the same functionality to apply to OpenLDAP pending merge and dependency update such thatldapchaiis able to catch this situation with an OpenLDAP backend; see ldapchai/ldapchai#25Given both PRs are merged, it will resolve #155