(maint) Scoping for Docker ARGs is not intuitive #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also moby/moby#37345 |
For multi-stage builds, setting `ARG`s before the `FROM` makes their scope global, but you still need to have an `ARG foo` line in each build step to use the global `ARG foo`. For single-stage builds, it doesn't make sense to define `ARG`s before the `FROM` except for `ARG`s used in the `FROM`, since global scope doesn't really help with only one stage.
underscorgan
force-pushed
the
arggggggs
branch
from
1aaa976
to
aab508b
Compare
Iristyle
reviewed
Jan 27, 2020
| ARG version="6.0.0" | ||
| ARG namespace="puppet" | ||
| FROM "$namespace"/puppetserver-base:"$version" | ||
| ARG vcs_ref |
There was a problem hiding this comment.
Since there's only one stage in this file, why not also move the version and namespace values below the FROM?
There was a problem hiding this comment.
because those are used in the FROM line
There was a problem hiding this comment.
Hahahaha, I suppose that's a good reason! Sheesh.
underscorgan
force-pushed
the
arggggggs
branch
from
aab508b
to
5e6b61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi-stage builds, setting
ARGs before theFROMmakes theirscope global, but you still need to have an
ARG fooline in each buildstep to use the global
ARG foo.For single-stage builds, it doesn't make sense to define
ARGs beforethe
FROMexcept forARGs used in theFROM, since global scopedoesn't really help with only one stage.