(MAINT) Refactor tasks to use shared code file #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
suggested changes
Mar 18, 2019
RandomNoun7
force-pushed
the
maint/refactor-shared-tasks-functions
branch
from
f2d5530
to
3cc361a
Compare
There was a large amount of repeated code in the tasks being added to the module. This change refactors the shared code into a file that is loaded into each task as it runs to cut down on the repetition of code.
RandomNoun7
force-pushed
the
maint/refactor-shared-tasks-functions
branch
from
3cc361a
to
37af3f4
Compare
michaeltlombardi
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a large amount of repeated code in the tasks being added to
the module. This change refactors the shared code into a file that is
loaded into each task as it runs to cut down on the repetition of code.