Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add doctype to some screenshot tests to avoid running them in quirks mode #12475

Merged
merged 1 commit into from
May 21, 2024

Conversation

lutien
Copy link
Contributor

@lutien lutien commented May 21, 2024

Adds DOCTYPE to the content of some screenshot tests to avoid running them in quirks mode

@lutien lutien force-pushed the add-doctype-to-screenshot-tests branch from 589e1d7 to 5a05de1 Compare May 21, 2024 16:13
@lutien lutien marked this pull request as ready for review May 21, 2024 16:49
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OrKoN OrKoN merged commit 045ed95 into puppeteer:main May 21, 2024
35 checks passed
@lutien lutien deleted the add-doctype-to-screenshot-tests branch May 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants