Updates the CI files. #5394
Closed
Updates the CI files. #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
reviewed
May 16, 2024
.github/workflows/publish.yml
Outdated
| uses: actions/upload-artifact/merge@v4 | ||
| with: | ||
| name: python-client.tar | ||
| pattern: *-python-client.tar |
There was a problem hiding this comment.
Maybe you need to escape the dot?
mdellweg
reviewed
May 17, 2024
.github/workflows/publish.yml
Outdated
Comment on lines
94
to
104
| name: "python-client.tar" | ||
| name: "core-python-client.tar" | ||
| path: "pulpcore/core-python-client.tar" | ||
| if-no-files-found: "error" | ||
| overwrite: true | ||
|
|
||
| - name: "Merge Python client packages" | ||
| uses: actions/upload-artifact/merge@v4 | ||
| with: | ||
| name: python-client.tar | ||
| pattern: "*-python-client.tar" | ||
|
|
There was a problem hiding this comment.
What are we even trying to solve here? I only see a single artifact uploaded. Why would merging it be an improvement?
There was a problem hiding this comment.
In v3, multiple uploads from multiple jobs could be done to the same Artifact. This would result in a single archive, which could be useful for sending to upstream systems outside of Actions via API or UI downloads.1
We can't do that anymore with v4.
Footnotes
-
Merging multiple artifacts https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#merging-multiple-artifacts ↩
There was a problem hiding this comment.
I think, we can:
pulp/plugin_template#866
[noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]