Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noissue]: Update django-import-export requirement from <3.4.0,>=2.9 to >=2.9,<4.1.0 #5317

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Updates the requirements on django-import-export to permit the latest version.

Release notes

Sourced from django-import-export's releases.

4.0.0

v4 release.

Changelog

Sourced from django-import-export's changelog.

4.0.0 (2024-04-27)

.. warning::

Version 4 introduces breaking changes.  Please refer to :doc:`release notes<release_notes>`.

Deprecations ############

  • Removed v3 deprecations (1629 <https://github.com/django-import-export/django-import-export/pull/1629>_)
  • Deprecation of ExportViewFormMixin (1666 <https://github.com/django-import-export/django-import-export/pull/1666>_)

Enhancements ############

  • Refactor ordering logic (1626 <https://github.com/django-import-export/django-import-export/pull/1626>_)

    • Refactor 'diff' logic to avoid calling dehydrate methods

    • Refactor declarations of fields, import_order and export_order to fix ordering issues

  • refactor to export HTML / formulae escaping updates (1638 <https://github.com/django-import-export/django-import-export/pull/1638>_)

  • removed unused variable Result.new_record (1640 <https://github.com/django-import-export/django-import-export/pull/1640>_)

  • Refactor resources.py to standardise method args (1641 <https://github.com/django-import-export/django-import-export/pull/1641>_)

  • added specific check for missing import_id_fields (1645 <https://github.com/django-import-export/django-import-export/pull/1645>_)

  • Enable optional tablib dependencies (1647 <https://github.com/django-import-export/django-import-export/pull/1647>_)

  • added :meth:~import_export.widgets.ForeignKeyWidget.get_lookup_kwargs to make it easier to override object lookup (1651 <https://github.com/django-import-export/django-import-export/pull/1651>_)

  • Standardised interface of :meth:~import_export.widgets.Widget.render (1657 <https://github.com/django-import-export/django-import-export/pull/1657>_)

  • Fix declaring existing model field(s) in ModelResource altering export order (1663 <https://github.com/django-import-export/django-import-export/pull/1663>_)

  • Added :meth:~import_export.resources.Resource.do_instance_save helper method (1668 <https://github.com/django-import-export/django-import-export/pull/1668>_)

  • Enable defining Resource model as a string (1669 <https://github.com/django-import-export/django-import-export/pull/1669>_)

  • Support multiple Resources for export (1671 <https://github.com/django-import-export/django-import-export/pull/1671>_)

  • Support export from model change form (1687 <https://github.com/django-import-export/django-import-export/pull/1687>_)

  • Import form defaults to read-only field if only one format defined (1690 <https://github.com/django-import-export/django-import-export/pull/1690>_)

  • Updated Admin UI to track deleted and skipped Imports (1691 <https://github.com/django-import-export/django-import-export/pull/1691>_)

  • Added customizable MediaStorage (1708 <https://github.com/django-import-export/django-import-export/pull/1708>_)

  • Added customization of Admin UI import error messages (1727 <https://github.com/django-import-export/django-import-export/pull/1727>_)

  • Improve output of error messages (1729 <https://github.com/django-import-export/django-import-export/pull/1729>_)

  • Added feature: selectable fields for admin export view (1734 <https://github.com/django-import-export/django-import-export/pull/1734>_)

  • Added specific check for declared :attr:~import_export.options.ResourceOptions.import_id_fields not in dataset (1735 <https://github.com/django-import-export/django-import-export/pull/1735>_)

  • added try / catch to :meth:~import_export.results.RowResult.add_instance_info to handle unserializable instances (1767 <https://github.com/django-import-export/django-import-export/pull/1767>_)

  • Add form error if source file contains invalid header (1780 <https://github.com/django-import-export/django-import-export/pull/1780>_)

  • Remove unneeded format method overrides (1785 <https://github.com/django-import-export/django-import-export/pull/1785>_)

  • Support dynamic selection of Resource class based on request property (1787 <https://github.com/django-import-export/django-import-export/pull/1787>_)

Fixes

  • dynamic widget parameters for CharField fixes 'NOT NULL constraint' error in xlsx (1485 <https://github.com/django-import-export/django-import-export/pull/1485>_)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [django-import-export](https://github.com/django-import-export/django-import-export) to permit the latest version.
- [Release notes](https://github.com/django-import-export/django-import-export/releases)
- [Changelog](https://github.com/django-import-export/django-import-export/blob/main/docs/changelog.rst)
- [Commits](django-import-export/django-import-export@2.9.0...4.0.0)

---
updated-dependencies:
- dependency-name: django-import-export
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Apr 29, 2024
@mdellweg
Copy link
Member

pulp [2051986a-893c-4983-a67c-d542c9e6fac3]: pulpcore.tasking.tasks:INFO: Task 018f2bad-98d3-703e-8613-e2610b5e19e8 failed (1: 'Domain' object has no attribute 'id' (OrderedDict([('file', 'artifact/1f/7a4d9c1117cb373f1ad69dc478553157e63c7a48f3760adaa7f405cef907df'), ('size', '1024'), ('md5', None), ('sha1', None), ('sha224', 'd7b59d4d4007f82eb560180a4f779212eb1aa5be7a4a51f34b1ed8dc'), ('sha256', '1f7a4d9c1117cb373f1ad69dc478553157e63c7a48f3760adaa7f405cef907df'), ('sha384', '89a7cfac03b7c2bd5a9692899f10c02f30ad8bb7183f65578ce926cce0ed5ffc04480c3a8efc4759d91fa4c5f7258da4'), ('sha512', 'cfd233bc3321b76b88edde6d06e73c310ed29f5b3bf70fb1bdf20390560e07e07671997347369f17418711eb702254016ac4ef6d036dab9b37a5e2e08f861e00'), ('pulp_domain', UUID('018f2ba8-996a-7f62-98f5-359ffa1a409b'))])))
pulp [2051986a-893c-4983-a67c-d542c9e6fac3]: pulpcore.tasking.tasks:INFO:   File "/usr/local/lib/python3.9/site-packages/pulpcore/tasking/tasks.py", line 70, in _execute_task
    result = func(*args, **kwargs)

  File "/usr/local/lib/python3.9/site-packages/pulpcore/app/tasks/importer.py", line 491, in pulp_import
    for ar_result in _import_file(os.path.join(temp_dir, ARTIFACT_FILE), ArtifactResource):

  File "/usr/local/lib/python3.9/site-packages/pulpcore/app/tasks/importer.py", line 273, in _import_file
    a_result = resource.import_data(data, raise_errors=True)

  File "/usr/local/lib/python3.9/site-packages/import_export/resources.py", line 838, in import_data
    result = self.import_data_inner(

  File "/usr/local/lib/python3.9/site-packages/import_export/resources.py", line 941, in import_data_inner
    raise exceptions.ImportError(

@ggainey
Copy link
Contributor

ggainey commented May 1, 2024

4.0 has A LOT of breaking changes, would not be surprised to find more problems once we address this one.

import/export doesn't support domains - looks like the domain-field for artifacts was ignored in import-export/3 and now Isn't. We def can't upgrade until we've done a pass over all the imp/export code, including in the plugins that support it.

@lubosmj
Copy link
Member

lubosmj commented May 6, 2024

@dependabot ignore this major version

@dependabot dependabot bot closed this May 6, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

OK, I won't notify you about version 4.x.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/pip/django-import-export-gte-2.9-and-lt-4.1.0 branch May 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants