Turn a few verb-only pytest fixtures into standard functions

[dralley]

[noissue]

[dralley]

@mdellweg

Probably not if someone started using it. That is until pulpcore 3.55.

I don't think we provide semantic versioning guarantees for test infrastructure? And any time we do test infra changes we often end up backporting it anyway, just to avoid incompatibility when future tests are added and backported.

None at all. Just use requests.get.

IMO, if we do that, and just eat the extra dependency, then we might as well just delete the function entirely. There's no point having an alias for a function as simple as requests.get

[mdellweg]

Well now here is the question in the wild: Do we consider the pytest-plugins of pulpcore (and others) to be part of the plugin api, and therefore subject to the deprecation policy?
I'm almost about to say "Yes". I agree we could be a bit more relaxed at that front, but knowingly breaking plugin ci is still a bad habit. For sure I cannot decide this alone.

Having a goal to render http_get deleted in the future is something i can only support.

[gerrod3]

I would say deprecate the fixtures, copy them to the utils and slowing switch tests over to importing the util functions. Once all the plugins have switched, then we can remove the fixtures.

[mdellweg]

I would say deprecate the fixtures, copy them to the utils and slowing switch tests over to importing the util functions. Once all the plugins have switched, then we can remove the fixtures.

It's the lower bounds test that makes me think about proper deprecation and removal only in a breaking change release.

[mdellweg]

I don't think we want this to stop being a fixture. It is using other fixtures.