Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure NGINX using API_ROOT & CONTENT_PATH_PREFIX #623

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Configure NGINX using API_ROOT & CONTENT_PATH_PREFIX #623

merged 1 commit into from
Apr 4, 2024

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Apr 3, 2024

fixes: #605

@gerrod3 gerrod3 mentioned this pull request Apr 3, 2024
Merged
mdellweg
mdellweg reviewed Apr 3, 2024
View reviewed changes
images/s6_assets/template_nginx.py Outdated

https = os.getenv("PULP_HTTPS", "false")
values = {
"https": https.lower() in ("true", "t", "yes", "y", "1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values documented anywhere?
Do all the other places recognize them in the same way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, previously we were only checking for 'true' after lower-casing.

dkliban
dkliban requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just check for value of 'true' for now. i'll add a new issue to allow all our boolean settings to accept a broader set of values.

@gerrod3 gerrod3 requested a review from dkliban April 3, 2024 21:02
dkliban
dkliban approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for this great feature!

I filed #624 to track the improvement for the boolean settings.

mdellweg
mdellweg approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution.

However (and this PR is not alone), it is kind of weird how we stretch the container idea. This almost looks like self modifying code.

@mdellweg mdellweg merged commit c2b209d into pulp:latest Apr 4, 2024
15 checks passed
@gerrod3 gerrod3 deleted the rproxy-apiroot branch April 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkliban dkliban dkliban approved these changes

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure NGINX using values of API_ROOT and CONTENT_PREFIX
3 participants
@gerrod3 @dkliban @mdellweg