Add oci-env edit-env command #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Nov 18, 2022
client/oci_env/commands.py
Outdated
|
|
||
| def edit_env(args): | ||
| editor = os.getenv("OCI_ENV_EDITOR", "vim") |
There was a problem hiding this comment.
I think "EDITOR" is a wildly used variable for this. Also xdg-open seems like a very good option. WDYT?
https://stackoverflow.com/questions/19252791/how-to-open-the-default-text-editor-in-linux
newswangerd
force-pushed
the
feature/edit-env-cmd
branch
from
12bcab1
to
1288745
Compare
decko
reviewed
Dec 12, 2022
|
|
||
|
|
||
| def edit_env(args): | ||
| editor = os.getenv("EDITOR", "vim") |
There was a problem hiding this comment.
Should we default it to a "more" common editor, like vi?
Not all distributions come with vim installed by default.
decko
reviewed
Dec 12, 2022
Comment on lines
+133
to
+134
| 'Edit your current environment file in vim. To change the default editor, set the ' | ||
| 'EDITOR environment variable to the path for the binary of your choosing.' |
There was a problem hiding this comment.
Suggested change
| 'Edit your current environment file in vim. To change the default editor, set the ' | |
| 'EDITOR environment variable to the path for the binary of your choosing.' | |
| 'Open the current environment file using your default EDITOR (or vi/vim if none is found).' | |
| 'To change the default editor, set the EDITOR environment variable to the path for ' | |
| 'binary of your choosing.' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launches vim to edit the current compose.env file. Works with the
-eflag. The editor can be configured via theOCI_ENV_EDITORenv var, but will default to vim.