Clean up sidebar plugins #812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 29, 2017
| end | ||
| end | ||
|
|
||
| def parse_request(_contents, _params) |
There was a problem hiding this comment.
Put empty method definitions on a single line.
publify_core/app/models/sidebar.rb
Outdated
| fields.reduce(sidebar: self) do |hash, field| | ||
| hash.merge(field.key => field.current_value(self)) | ||
| end | ||
| def parse_request(contents, params) |
There was a problem hiding this comment.
Use delegate to define delegations.
publify_core/app/models/sidebar.rb
Outdated
| end | ||
|
|
||
| def short_name | ||
| self.class.short_name | ||
| def to_locals_hash |
There was a problem hiding this comment.
Use delegate to define delegations.
publify_core/app/models/sidebar.rb
Outdated
| configuration.description | ||
| end | ||
|
|
||
| def fields |
There was a problem hiding this comment.
Use delegate to define delegations.
publify_core/app/models/sidebar.rb
Outdated
| else | ||
| self.class.fieldmap | ||
| end | ||
| def display_name |
There was a problem hiding this comment.
Use delegate to define delegations.
publify_core/app/models/sidebar.rb
Outdated
|
|
||
| def fields | ||
| self.class.fields | ||
| def content_partial |
There was a problem hiding this comment.
Use delegate to define delegations.
| @@ -10,7 +10,7 @@ def index | |||
| def update | |||
| @sidebar = Sidebar.where(id: params[:id]).first | |||
| @old_s_index = @sidebar.staged_position || @sidebar.active_position | |||
| @sidebar.update_attributes params[:configure][@sidebar.id.to_s].permit! | |||
| @sidebar.update_attribute :config, params[:configure][@sidebar.id.to_s].permit!.to_hash | |||
There was a problem hiding this comment.
Avoid using update_attribute because it skips validations.
mvz
force-pushed
the
clean-up-sidebar-plugins
branch
3 times, most recently
from
b81b687
to
10bdcc6
Compare
|
This seemed like a good idea at the time, but now I'm not so sure. |
Merged
mvz
force-pushed
the
clean-up-sidebar-plugins
branch
from
3cce74b
to
eccd5cb
Compare
mvz
force-pushed
the
clean-up-sidebar-plugins
branch
from
eccd5cb
to
cb65f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.