New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table redesign for action buttons #626
base: master
Are you sure you want to change the base?
Conversation
@@ -9,6 +9,7 @@ | |||
<table class='table table-striped'> | |||
<thead> | |||
<tr class='noborder'> | |||
<th>Actions</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a translation key for this as in the other header cells.
I like this change. Can you please rebase your branch so it doesn't include the 404 page, which is subject of another PR? |
09cf371
to
96bf360
Compare
Removed the 404 page commit |
I think I've covered all and added internationalization keys for Action :) |
I'm not a great fan of it if you let the table scale the action column width to (table size / nb of columns) px. Moving the buttons under the title had 3 purposes:
|
Maybe we can make the action column not scale, then? |
@jacemonje Any chance you could address @fdv's comment? |
I separated the action buttons in every table structure in Publify for a cleaner and IMHO better UI and UX for users