Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table redesign for action buttons #626

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jacemonje
Copy link
Contributor

I separated the action buttons in every table structure in Publify for a cleaner and IMHO better UI and UX for users

screen shot 2015-06-29 at 9 09 42 am

screen shot 2015-06-29 at 8 31 55 am

@@ -9,6 +9,7 @@
<table class='table table-striped'>
<thead>
<tr class='noborder'>
<th>Actions</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a translation key for this as in the other header cells.

@mvz
Copy link
Member

mvz commented Jun 29, 2015

I like this change.

Can you please rebase your branch so it doesn't include the 404 page, which is subject of another PR?

@jacemonje
Copy link
Contributor Author

Removed the 404 page commit

@jacemonje
Copy link
Contributor Author

I think I've covered all and added internationalization keys for Action :)

@fdv
Copy link
Member

fdv commented Jun 30, 2015

I'm not a great fan of it if you let the table scale the action column width to (table size / nb of columns) px.

Moving the buttons under the title had 3 purposes:

  • leaving more space to the title when reading on a small screen (iPad, cellphone)
  • avoiding that "actions take 20% of the screen" thing. Actions should have a fixed width
  • I don't remember what I was about to write here.

@mvz
Copy link
Member

mvz commented Jun 30, 2015

Maybe we can make the action column not scale, then?

@mvz
Copy link
Member

mvz commented Aug 12, 2015

@jacemonje Any chance you could address @fdv's comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants