Made a 404 page for publify with relevant links #623
Conversation
| <p>If you are the application owner check the logs for more information. | ||
| <br> | ||
| <br> | ||
| <a href="http://localhost:3000/">Home</a> | |
There was a problem hiding this comment.
This link won't work in a production environment.
There was a problem hiding this comment.
So I'll just remove it?
There was a problem hiding this comment.
Tricky. You could simply change the links to just ba a path: /, /notes, and /archives, but in particular notes may not be relevant, and this will break if the blog is not located at the root of the web server.
Removing the links is probably the best option.
|
I'll go with removing the links instead. Point about the blog not being in the root +1 |
|
Since our routing system has a catch all, it's easy to render a 404 page and use an erb template. That way, you can build the links from the blog settings. That's what I've done on my own blog, and the 404 page benefits from the blog caching. |
| <p>You may have mistyped the address or the page may have moved.</p> | ||
| </div> | ||
| <p>If you are the application owner check the logs for more information.</p> | ||
| <p>If you are the application owner check the logs for more information. | ||
| <br> |
There was a problem hiding this comment.
This <br> could be removed, unless you're using it to force an extra line
|
@mvz I'll remove the Publify heading? IMHO it adds a nice touch to the page. |
It looks nice, but it seems a bit too prominent. I would rather see my blog's name there :-). Following @fdv's suggestion, you could do that, and also add nice links. TL;DR: I like the design, I would love to have both the links and the smaller heading, but both should be dynamic. @fdv, is anything more needed than just moving the 404 to a template inside |
|
In my theme, the 404 page is in Need to test that with 500 as well when I get time to do not work not family things. |
|
I see. I'll work on moving |
|
Just to note: I think the internationalization and translation keys are broken in the en.yml: views/errors/404.html.erb rendered 404 Will try to fix this along with the error pages. |
|
Are there any updates relating to this PR? @jacemonje @mvz |
|
@malachaifrazier not really, no. This should probably go to |
The stock rails 404 looks really bad so I took the liberty of making a new one