Skip to content

Commit

Permalink
Merge pull request #1016 from publify/force-minimum-nokogiri-version
Browse files Browse the repository at this point in the history
Force minimum nokogiri version to avoid security issues
  • Loading branch information
mvz committed Oct 2, 2021
2 parents e6611f2 + fecc9da commit 0df8d58
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ruby.yml
Expand Up @@ -22,7 +22,7 @@ jobs:

strategy:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7]
ruby: [2.5, 2.6, 2.7]

services:
postgres:
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:

strategy:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7]
ruby: [2.5, 2.6, 2.7]

services:
mysql:
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:

strategy:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7]
ruby: [2.5, 2.6, 2.7]

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions Gemfile
Expand Up @@ -28,6 +28,9 @@ gem "non-digest-assets", "~> 1.0"
gem "rake", "~> 13.0"
gem "reverse_markdown", "~> 2.0"

# Force minimum nokogiri version to avoid security issues
gem "nokogiri", ">= 1.12.5"

# Force older sprockets
gem "sprockets", "~> 3.0"

Expand Down
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -58,7 +58,7 @@ be broken there at any time, so tread carefully!

To install Publify you need the following:

- CRuby (MRI) 2.4, 2.5, 2.6 or 2.7
- CRuby (MRI) 2.5, 2.6 or 2.7
- Ruby on Rails 5.2.x
- A database engine, MySQL, PgSQL or SQLite3
- A compatible JavaScript installation for asset compilation. See
Expand Down Expand Up @@ -108,7 +108,7 @@ Next, you need to update `Gemfile`. You should remove the `mysql2` and
```ruby
source 'https://rubygems.org'

ruby '2.4.3' # Or whichever version you're running
ruby '2.7.4' # Or whichever version you're running
gem 'pg'
gem 'rails_12factor'

Expand Down

0 comments on commit 0df8d58

Please sign in to comment.