Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created drafts page #9893

Merged
merged 1 commit into from
Jul 13, 2021
Merged

created drafts page #9893

merged 1 commit into from
Jul 13, 2021

Conversation

TildaDares
Copy link
Member

@TildaDares TildaDares commented Jul 8, 2021

Fixes #9660
Part of larger planning issue in #9667

Screenshot 2021-07-09 at 00 14 56

Responsiveness

Screen.Recording.2021-07-09.at.00.21.38.mov

When a user who is neither a moderator or the drafts author tries to visit the drafts page, a flash notice is displayed and the user is redirected to the homepage

Screenshot 2021-07-09 at 00 23 25

@TildaDares TildaDares requested a review from a team as a code owner July 8, 2021 23:27
@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2021

@codeclimate
Copy link

codeclimate bot commented Jul 8, 2021

Code Climate has analyzed commit 56c3e6e and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #9893 (56c3e6e) into main (d12a468) will increase coverage by 3.89%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9893      +/-   ##
==========================================
+ Coverage   78.24%   82.13%   +3.89%     
==========================================
  Files          98       98              
  Lines        5947     5957      +10     
==========================================
+ Hits         4653     4893     +240     
+ Misses       1294     1064     -230     
Impacted Files Coverage Δ
app/channels/room_channel.rb 71.42% <0.00%> (ø)
app/controllers/tag_controller.rb 80.42% <ø> (+0.61%) ⬆️
app/helpers/application_helper.rb 85.41% <66.66%> (+5.20%) ⬆️
app/controllers/notes_controller.rb 84.87% <100.00%> (+0.40%) ⬆️
app/models/tag.rb 97.51% <100.00%> (+12.01%) ⬆️
app/models/user.rb 86.12% <100.00%> (+3.32%) ⬆️
app/models/revision.rb 88.29% <0.00%> (+3.19%) ⬆️
app/models/user_tag.rb 100.00% <0.00%> (+4.34%) ⬆️
... and 9 more

@TildaDares TildaDares requested a review from RuthNjeri July 9, 2021 08:25
Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TildaDares wow this looks great! 🎉 The responsive design and all the tests 💯

Maybe we can have the route under notes only like notes/drafts but this is just my suggestion @jywarren can comment better

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, good job @TildaDares! 🎉

Aside from @Tlazypanda's suggestion which makes sense...I think the PR is good to go 🚀

@noi5e
Copy link
Contributor

noi5e commented Jul 12, 2021

@TildaDares Looks good to me! Great work!

@noi5e
Copy link
Contributor

noi5e commented Jul 12, 2021

This is unrelated and I'm sure it doesn't affect this PR at all, but I'm just noting that codecov has a new feature displaying on this PR which I can't make sense of:

Screen Shot 2021-07-12 at 10 51 58 AM

@TildaDares
Copy link
Member Author

@Tlazypanda @RuthNjeri You're right about using the notes/drafts route but using that route would mean that moderators wouldn't be able to see other users drafts page. I'm fine with other option though.

@jywarren
Copy link
Member

noting that codecov has a new feature

whoa... codecov had been a bit broken. Maybe they introduced a new system upstream to fix that but it came with some additional features or settings defaults?

@jywarren jywarren merged commit eba4980 into publiclab:main Jul 13, 2021
@jywarren
Copy link
Member

Looks awesome. Thanks @TildaDares !!!!!

@TildaDares TildaDares deleted the drafts-page branch July 13, 2021 14:59
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Add Listing of Draft Posts to Profile Pages
5 participants