Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents menu for wikis #9711

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Table of contents menu for wikis #9711

merged 1 commit into from
Jun 1, 2021

Conversation

TildaDares
Copy link
Member

Fixes #9512

Part of larger planning issue at #9667

Screen.Recording.2021-05-31.at.16.20.17.mov

Screenshot 2021-05-31 at 16 27 24

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented May 31, 2021

@codeclimate
Copy link

codeclimate bot commented May 31, 2021

Code Climate has analyzed commit d9859ba and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9c43a77). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9711   +/-   ##
=======================================
  Coverage        ?   82.01%           
=======================================
  Files           ?       98           
  Lines           ?     5928           
  Branches        ?        0           
=======================================
  Hits            ?     4862           
  Misses          ?     1066           
  Partials        ?        0           

@jywarren jywarren changed the title menu for wikis Table of contents menu for wikis Jun 1, 2021
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @TildaDares !!!! Very nicely done. Fantastic and the community will love it.

@jywarren jywarren merged commit 697b585 into publiclab:main Jun 1, 2021
@jywarren
Copy link
Member

jywarren commented Jun 1, 2021

@TildaDares this is something you might want to share on the live site once it publishes, in the form of a note, like "New feature: Table of Contents on wiki pages" and you could briefly describe how it works, and share these screenshots! I think folks would really love it.

@TildaDares
Copy link
Member Author

Thanks @jywarren and sharing it on the live site sounds like a great idea 🎉

@TildaDares TildaDares deleted the toc branch June 1, 2021 16:31
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table of contents under an icon for wiki/Markdown pages, like GitHub does now!
2 participants