New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header button toolbar fix for responsive layouts #9343
Conversation
Code Climate has analyzed commit 37796b8 and detected 0 issues on this pull request. View more on Code Climate. |
@waridrox Can you share a screenshot or recording of changes |
Codecov Report
@@ Coverage Diff @@
## main #9343 +/- ##
=======================================
Coverage ? 78.14%
=======================================
Files ? 98
Lines ? 5870
Branches ? 0
=======================================
Hits ? 4587
Misses ? 1283
Partials ? 0 |
I've shared those in the issue itself...Here's the final output ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉 thanks for working on this @waridrox
Thanks @noi5e and @govindgoel for the reviews
Fixes #9342
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below@noi5e kindly review this. Thanks :)