[Outreachy]Add Nearby Activity

[RuthNjeri]

Fixes #9159

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Before

After adding location

[gitpod-io]

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@5929949). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9202   +/-   ##
=======================================
  Coverage        ?   81.81%           
=======================================
  Files           ?      100           
  Lines           ?     5955           
  Branches        ?        0           
=======================================
  Hits            ?     4872           
  Misses          ?     1083           
  Partials        ?        0           

[jywarren]

Really nice! Thanks Ruth!!!!!! 🎉

[RuthNjeri]

Investigating why the test is failing, not sure what is causing it...

[jywarren]

We should be able to fix this once publiclab/leaflet-environmental-layers#504 (comment) is merged -- instructions there!

plots2/app/assets/javascripts/leafletHelper.js

Lines 116 to 122 in 30fb696

	function setupLEL(map, markers_hash = null, params = {}) {
	var options = {};
	options.layers = params.layers || []; // display these layers on the map
	options.limitMenuTo = params.limitMenuTo || []; // limit available layers in menu to only those listed, default all layers in menu
	options.setHash = params.setHash || false;
	options.mainContent = params.mainContent || ""; // "content" to show site content, default "" shows no site content
	options.displayAllLayers = params.displayAllLayers || false; // turn on display for all maps available in menu

is where the extra option options.imageLoadingUrl = "someGifAnimation.gif" could be set. We may need to add a spinning icon of our own, in this PR, or we can use publiclab/leaflet-environmental-layers#473

This should resolve #5095 as well and we can close that!

[RuthNjeri]

Thanks @jywarren 🎉

Who knew that it was not a spelling error 😅 ...not me

[jywarren]

OK! I made the change in your branch, and now, i think we have to release a new version of LEL and wait for Dependabot to help us merge it in... or we could increment the version in this PR alternatively!

[jywarren]

OK, i'll do my best to publish this tonight or tomorrow and we'll watch for Dependabot!!

[jywarren]

Should happen from in publiclab/leaflet-environmental-layers#507

[jywarren]

It'll be v2.4.2 of the leaflet-environmental-layers library! https://www.npmjs.com/package/leaflet-environmental-layers

[jywarren]

yay!! #9208

[RuthNjeri]

Hi @jywarren this is ready to merge... the owmloading.gif error was still happening with the system test I wrote... the error 'v2/owmloading.gif' kept happening with the test I wrote to ensure that subscribe tags do not show up in the trending tags section...I rewrote that test into a functional test and everything is working fine now...

[codeclimate]

Code Climate has analyzed commit 4ca801c and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

That was really odd, it hadn't pulled in the latest changes from publiclab/plots2 main so I did that again... then ran yarn install one more time. Now it works, i confirmed in GitPod. I re-added that test just to be sure but, if you think it's more efficient anyways as a functional test, feel free to remove it one more time, since system tests are a bit expensive.

Thanks Ruth, this should 🤞 pass and we can merge!!!

[cesswairimu]

🎉 🎉

[jywarren]

Thanks @cesswairimu !!!

[jywarren]

Yayyyyyy this is great!! 🎉 🎉 🎉 🎉

[RuthNjeri]

Amazing!! Thanks @jywarren