Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include description of usefulness related to the figaro gem #9074

Closed
wants to merge 1 commit into from
Closed

Include description of usefulness related to the figaro gem #9074

wants to merge 1 commit into from

Conversation

hector4213
Copy link

Fixes #9009(<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2021

@codeclimate
Copy link

codeclimate bot commented Jan 25, 2021

Code Climate has analyzed commit 2ae0cfe and detected 0 issues on this pull request.

View more on Code Climate.

@hector4213 hector4213 changed the title Include usefulness of the figaro gem Include description of usefulness related to the figaro gem Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@38e37eb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9074   +/-   ##
=======================================
  Coverage        ?   82.05%           
=======================================
  Files           ?      100           
  Lines           ?     5941           
  Branches        ?        0           
=======================================
  Hits            ?     4875           
  Misses          ?     1066           
  Partials        ?        0           

@cesswairimu
Copy link
Collaborator

Hello @hector4213 it seems like this was solved in another PR. Please do consider checking the comments on the issue in future to see if someone is already working on it before starting. Closing this... Feel free to mention here #9083 if you need help finding another issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment explaining the usefulness of "Figaro" gem
2 participants