Reorganize comment.js & dragdrop.js Script-Loading #9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noi5e
added
JavaScript
feature
|
|
Codecov Report
@@ Coverage Diff @@
## main #9037 +/- ##
=======================================
Coverage ? 82.05%
=======================================
Files ? 100
Lines ? 5939
Branches ? 0
=======================================
Hits ? 4873
Misses ? 1066
Partials ? 0 |
noi5e
commented
Jan 19, 2021
| @@ -1,5 +1,4 @@ | |||
| (function() { | |||
|
|
|||
| $(function() { | |||
| $('.comment-form').each(function() { | |||
There was a problem hiding this comment.
It turns out that all along, these eventHandlers weren't being attached on document.load!
|
Code Climate has analyzed commit 7a1b0f2 and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Jan 19, 2021
|
Looks great! Shall we merge? Omg event listeners initialization is such a common JS bug!!! 😭😂🎉 |
|
@jywarren Yep, ready to merge! |
|
🎉 🎉 🎉 🎉 |
noi5e
changed the title
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
…b#9037) * move comment.js & dragdrop.js to higher-level views publiclab#9004 * attach eventListeners on document.load publiclab#9004 * move dragdrop.js & comment.js to notes/comments partial publiclab#9004
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
…b#9037) * move comment.js & dragdrop.js to higher-level views publiclab#9004 * attach eventListeners on document.load publiclab#9004 * move dragdrop.js & comment.js to notes/comments partial publiclab#9004
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
…b#9037) * move comment.js & dragdrop.js to higher-level views publiclab#9004 * attach eventListeners on document.load publiclab#9004 * move dragdrop.js & comment.js to notes/comments partial publiclab#9004
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
…b#9037) * move comment.js & dragdrop.js to higher-level views publiclab#9004 * attach eventListeners on document.load publiclab#9004 * move dragdrop.js & comment.js to notes/comments partial publiclab#9004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of an object-oriented refactoring of the Comment Editor. See #9004 for more details.
Currently
comment.jsanddragdrop.jsare loaded once per every comment form on a page:plots2/app/views/comments/_form.html.erb
Lines 107 to 110 in f0be879
They really only need to be loaded once per page (not 5 times on a page with 5 comments)!
Both scripts (but particularly
dragdrop.js) have eventListeners which can get attached multiple times to the same element if each script is loaded multiple times.Simplifying the script loading is going to help with refactoring
editor.js.(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)