Fix Rich-Text Cross-Wiring in Comment Forms #9011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
noi5e
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit ef0ab12 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9011 +/- ##
=======================================
Coverage ? 82.03%
=======================================
Files ? 100
Lines ? 5933
Branches ? 0
=======================================
Hits ? 4867
Misses ? 1066
Partials ? 0 |
noi5e
commented
Jan 14, 2021
| $E[action](); // call the appropriate editor function | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I have doubts about if this is the right place to put this click eventHandler.
noi5e
commented
Jan 14, 2021
| @@ -32,20 +32,10 @@ jQuery(function() { | |||
| $('#side-dropzone').removeClass('hover'); | |||
| }); | |||
| $('.dropzone').on('drop',function(e) { | |||
| // this 'drop' listener is also reused for pages with just one form, ie. /wiki/new | |||
| const closestCommentFormWrapper = e.target.closest('div.comment-form-wrapper'); // this returns null if there is no match | |||
| const params = getEditorParams(e.target); // defined in editorHelper.js | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Am I doing this right: calling on editorHelper.js? I browsed the Rails guide to JS assets, but am not sure if what I'm doing falls under 'best practices'. Would appreciate some pointers if you have any.
There was a problem hiding this comment.
Yes that looks fine to me
noi5e
added
the
bug
|
@jywarren Had some questions about requiring JS files in Rails, and where to put a click eventHandler. Other than that, this is ready to merge! |
sagarpreet-chadha
approved these changes
Jan 15, 2021
| @@ -32,20 +32,10 @@ jQuery(function() { | |||
| $('#side-dropzone').removeClass('hover'); | |||
| }); | |||
| $('.dropzone').on('drop',function(e) { | |||
| // this 'drop' listener is also reused for pages with just one form, ie. /wiki/new | |||
| const closestCommentFormWrapper = e.target.closest('div.comment-form-wrapper'); // this returns null if there is no match | |||
| const params = getEditorParams(e.target); // defined in editorHelper.js | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Yes that looks fine to me
noi5e
changed the title
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* add rich-text tests publiclab#8478 * fix indentation publiclab#8478 * delete onclick for rich-text buttons; add data-action attribute publiclab#8478 * add click handler for rich-text buttons publiclab#8478 * extract code to editorHelper for DRY publiclab#8478 * require editorHelper.js publiclab#8478 * change == to === publiclab#8478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8478
This PR is a duplicate of #9003, which is now closed (I did a
git rebase mainin the other branch, which was bundling changes frommaininto the PR. Couldn't figure out how to undo that).From the other PR write-up:
(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)