[System Tests] Post Full Page, Then Immediately Comment #8879

noi5e · 2020-12-21T20:15:33Z

Merge this PR first! (I have another one open at #8881)

Also made new helper function to retrieve node path in the comment tests.

(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

gitpod-io · 2020-12-21T20:15:37Z

codecov · 2020-12-21T20:18:34Z

Codecov Report

❗ No coverage uploaded for pull request base (main@0f770f2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8879   +/-   ##
=======================================
  Coverage        ?   81.92%           
=======================================
  Files           ?      100           
  Lines           ?     5948           
  Branches        ?        0           
=======================================
  Hits            ?     4873           
  Misses          ?     1075           
  Partials        ?        0

Sagarpreet · 2020-12-22T17:19:21Z

test/system/comment_test.rb

      page.evaluate_script("addComment('#{comment_text}', '/comment/create/#{nodes(node_name).nid.to_s}')")
      assert_selector('#comments-list .comment-body p', text: comment_text)
    end

    test "#{page_type_string}: reply to existing comment" do
-      node_name == :wiki_page ? (visit nodes(node_name).path + '/comments') : (visit nodes(node_name).path)
+      visit get_visit_path(node_name, nodes(node_name).path)


This is repeated 2 times, is it intentional?

Hi Sagarpreet! Which part are you thinking about?

visit get_visit_path looks a little redundant and confusing, maybe I should rename the method to something like get_path or get_path_string.

visit is the testing method that visits the page

get_visit_path is a helper function I wrote to retrieve the path for the testing node. mainly because wiki comments are only viewable at /wiki/wiki-name/comments. (i have to add '/comments' to the end of the path string)

there were two addComment tests that existed before I was an intern. for some reason, there are two tests for this function. one tests addComment(text, URL), the other just addComment(text).

I was thinking that maybe these tests aren't necessary, aren't really 'system' tests, and could be removed.

I like get_path here, thanks!

If the 2 old tests are redundant and you're confident we test them in other ways, that's fine. Are they not system tests because they test only the functions and not the full-stack interaction? I think there may be an ambiguity because there wasn't another way to test JS functions, and these would address both JS and Ruby, so they are "mostly-full-stack" still... what do you think?

My apologies for missing this PR i see it's been open a while. Thanks!

We can merge before or after changing to get_path and if you'd still like to eliminate the old tests we can do that in another PR, perhaps? Thank you!!!

Changed to get_path...

Re: addComment, that's a good point, I guess the JS wouldn't be tested in any other way besides here. They're also pretty lightweight and fast-running (compared to mine 😛).

It seems like addComment isn't used anywhere on the site besides in these tests... Yet! I guess that'll be one of the things I do, to try to implement it in most comment forms (it's on my to-dos in the planning issue)... I think once that goes live, then these tests could be removed, because the the manual commenting tests would run via addComment.

Sagarpreet · 2020-12-22T17:21:11Z

test/system/comment_test.rb

@@ -80,8 +85,47 @@ def setup
      find("p", text: comment_response_text)
    end

+    test "post #{page_type_string}, then comment on FRESH #{page_type_string}" do
+      title_text, body_text = String.new, String.new
+      case page_type_string


Wow, this is really cool !!
How is page_type_string getting substituted?

It's happening here:

plots2/test/test_helper.rb

Lines 43 to 50 in 9fb5d65

# used in comment_test.rb

def page_types

{

:note => :comment_note,

:question => :comment_question,

:wiki => :wiki_page

}

end

Helper function that returns the name of the node fixture :)

noi5e · 2021-01-06T00:44:29Z

Ready to merge!

jywarren · 2021-01-06T01:28:27Z

Awesome! Just one conflict to resolve!!

noi5e · 2021-01-06T03:32:53Z

Resolved!

codeclimate · 2021-01-06T03:33:44Z

Code Climate has analyzed commit 9b5632a and detected 0 issues on this pull request.

View more on Code Climate.

jywarren · 2021-01-06T04:36:38Z

Fantastic!!!!

* new test: post fresh page, then comment on it * refactored get_path method for readability

new test: post fresh page, then comment on it

d2b3add

noi5e added testing issues are usually for adding unit tests, integration tests or any other tests for a feature outreachy labels Dec 21, 2020

noi5e added this to the [Outreachy] Comment Editor Winter 2020 milestone Dec 21, 2020

noi5e requested review from jywarren, sagarpreet-chadha and cesswairimu December 21, 2020 20:15

This was referenced Dec 22, 2020

[System Tests] Post Replies with Multiple Comment Boxes Open #8881

Merged

OLD CLOSED Comment Editor Overhaul Issue #8775

Closed

Sagarpreet reviewed Dec 22, 2020

View reviewed changes

noi5e changed the title ~~New Test: Post, then Comment on Fresh Post~~ Testing: Post Full Page, Then Immediately Comment Dec 27, 2020

jywarren approved these changes Jan 5, 2021

View reviewed changes

refactored get_path method for readability

23e22c1

Merge branch 'main' into test/post-then-comment

9b5632a

jywarren merged commit 0f4dec9 into publiclab:main Jan 6, 2021

noi5e deleted the test/post-then-comment branch January 6, 2021 04:39

noi5e mentioned this pull request Jan 23, 2021

Comment Editor Overhaul Project [Outreachy] #9069

Open

noi5e changed the title ~~Testing: Post Full Page, Then Immediately Comment~~ [System Tests] Post Full Page, Then Immediately Comment Jan 23, 2021

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021

Testing: Post Full Page, Then Immediately Comment (publiclab#8879)

b5c2db9

* new test: post fresh page, then comment on it * refactored get_path method for readability

lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021

Testing: Post Full Page, Then Immediately Comment (publiclab#8879)

933ab71

* new test: post fresh page, then comment on it * refactored get_path method for readability

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021

Testing: Post Full Page, Then Immediately Comment (publiclab#8879)

cffaac8

* new test: post fresh page, then comment on it * refactored get_path method for readability

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021

Testing: Post Full Page, Then Immediately Comment (publiclab#8879)

229dc94

* new test: post fresh page, then comment on it * refactored get_path method for readability

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[System Tests] Post Full Page, Then Immediately Comment #8879

[System Tests] Post Full Page, Then Immediately Comment #8879

noi5e commented Dec 21, 2020 •

edited

gitpod-io bot commented Dec 21, 2020 •

edited

codecov bot commented Dec 21, 2020 •

edited

Sagarpreet Dec 22, 2020

noi5e Dec 22, 2020

jywarren Jan 5, 2021

jywarren Jan 5, 2021

noi5e Jan 6, 2021

Sagarpreet Dec 22, 2020

noi5e Dec 22, 2020

noi5e commented Jan 6, 2021

jywarren commented Jan 6, 2021

noi5e commented Jan 6, 2021

codeclimate bot commented Jan 6, 2021

jywarren commented Jan 6, 2021

	# used in comment_test.rb
	def page_types
	{
	:note => :comment_note,
	:question => :comment_question,
	:wiki => :wiki_page
	}
	end

[System Tests] Post Full Page, Then Immediately Comment #8879

[System Tests] Post Full Page, Then Immediately Comment #8879

Conversation

noi5e commented Dec 21, 2020 • edited

gitpod-io bot commented Dec 21, 2020 • edited

codecov bot commented Dec 21, 2020 • edited

Codecov Report

Sagarpreet Dec 22, 2020

Choose a reason for hiding this comment

noi5e Dec 22, 2020

Choose a reason for hiding this comment

jywarren Jan 5, 2021

Choose a reason for hiding this comment

jywarren Jan 5, 2021

Choose a reason for hiding this comment

noi5e Jan 6, 2021

Choose a reason for hiding this comment

Sagarpreet Dec 22, 2020

Choose a reason for hiding this comment

noi5e Dec 22, 2020

Choose a reason for hiding this comment

noi5e commented Jan 6, 2021

jywarren commented Jan 6, 2021

noi5e commented Jan 6, 2021

codeclimate bot commented Jan 6, 2021

jywarren commented Jan 6, 2021

noi5e commented Dec 21, 2020 •

edited

gitpod-io bot commented Dec 21, 2020 •

edited

codecov bot commented Dec 21, 2020 •

edited