New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System Tests] Comment On Question, Then Immediately Respond #8851
Merged
jywarren
merged 3 commits into
publiclab:main
from
noi5e:test/question-fresh-comment-response
Dec 15, 2020
Merged
[System Tests] Comment On Question, Then Immediately Respond #8851
jywarren
merged 3 commits into
publiclab:main
from
noi5e:test/question-fresh-comment-response
Dec 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noi5e
added
outreachy
testing
issues are usually for adding unit tests, integration tests or any other tests for a feature
labels
Dec 15, 2020
Code Climate has analyzed commit f406c0d and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. It passes locally? Awesome work!
Ah yeah, I didn't make that clear: yep the tests look good locally! |
Fantastic!! |
noi5e
changed the title
[Outreachy Comment Editor] New test: Post comment on question, then respond to it
Testing: Comment On Question, Then Immediately Respond
Dec 27, 2020
noi5e
changed the title
Testing: Comment On Question, Then Immediately Respond
[System Tests] Comment On Question, Then Immediately Respond
Jan 23, 2021
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
…espond to it (publiclab#8851) * add test for question: comment then respond * fixtures for question w/ comment
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
…espond to it (publiclab#8851) * add test for question: comment then respond * fixtures for question w/ comment
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
…espond to it (publiclab#8851) * add test for question: comment then respond * fixtures for question w/ comment
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
…espond to it (publiclab#8851) * add test for question: comment then respond * fixtures for question w/ comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new test for Question pages:
Small concerns:
(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)