[System Tests] addComment(URL), Add New Note Fixture

[noi5e]

Not to be confused with my other current PR, #8801, which adds a new test for Question pages. Please review that one first, it has more extensive write-up!

This test was fairly straightforward to write compared to questions.

I renamed some of the tests to distinguish between notes, questions, and the old tests for commenting on wiki pages.

I simulated a new note in the fixtures for testing comments:

nodes.yml

comment_note: # for testing comments on notes
  nid: 38
  uid: 2
  title: "Please don't comment here"
  path: "/notes/jeff/12-08-2020/please-don-t-comment-here"
  created: <%= DateTime.new(2020,12,8).to_i %>
  changed: <%= DateTime.new(2020,12,8).to_i %>
  status: 1
  type: "note"
  cached_likes: 0
  slug: "note-please-don-t-comment-here"

revisions.yml

comment_note: # for testing comments on notes
  nid: 38
  uid: 2
  title: "Please don't comment here"
  body: "I beg you, please"
  timestamp: <%= DateTime.new(2020,12,8).to_i %>
  status: 1

The test:

test 'note: comment via JavaScript, with comment body + URL' do
  visit nodes(:comment_note).path
  page.evaluate_script("addComment('hahaha', '/comment/create/38')")
  assert_selector('#comments-list .comment-body p', text: 'hahaha')
end

(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

[gitpod-io]

[jywarren]

This looks great, all excellent clarifications and additions. If it runs smoothly in GitPod, let's mark it ready to merge? Hopefully we figure out the testing situation very soon and can merge this!

[pydevsg]

Awesome work @noi5e 🎉

[noi5e]

I caught a test that was failing because I created a new fixture:

plots2/test/unit/node_test.rb

Lines 345 to 354 in ff3417a

	test 'should find all research notes' do
	notes = Node.research_notes
	expected = [nodes(:one), nodes(:spam), nodes(:first_timer_note), nodes(:blog),
	nodes(:moderated_user_note), nodes(:activity), nodes(:upgrade),
	nodes(:draft), nodes(:post_test1), nodes(:post_test2),
	nodes(:post_test3), nodes(:post_test4), nodes(:scraped_image), nodes(:search_trawling),
	nodes(:purple_air_without_hyphen), nodes(:purple_air_with_hyphen),
	nodes(:sun_note), nodes(:sunny_day_note)]
	assert_equal expected, notes
	end

Pushed new commits and it fixes the fail!

There might be a few more changes that need to be made. Going through the tests locally right now.

[noi5e]

Caught two more tests that were failing bc of the new note fixture:

plots2/test/functional/notes_controller_test.rb

Lines 362 to 373 in ff3417a

	test 'first-timer moderated note (status=4) shown to author in list view with notice' do
	node = nodes(:first_timer_note)
	UserSession.create(node.author)
	assert_equal 4, node.status
	get :index
	assert_response :success
	selector = css_select 'div.note'
	assert_equal 27, selector.size
	assert_select "div p", 'Pending approval by community moderators. Please be patient!'
	end

plots2/test/functional/notes_controller_test.rb

Lines 391 to 402 in ff3417a

	test 'first-timer moderated note (status=4) shown to moderator with notice and approval prompt in list view' do
	UserSession.create(users(:moderator))
	node = nodes(:first_timer_note)
	assert_equal 4, node.status
	get :index
	assert_response :success
	selector = css_select 'div.note'
	assert_equal 27, selector.size
	assert_select 'a[data-test="spam"]','Spam'
	end

27 should be 28 in both because of the new note I created. Pushed the changes! I think this PR is good, no other new failed tests AFAIK locally.

[Sagarpreet]

🎉 🎉 🎉
All tests are passing now, right?

[Sagarpreet]

Correct 👍

[jywarren]

Awesome, now that #8801 is merged, can you resolve the conflicts noted by GitHub and then we should be good to merge this (bypassing Travis) too? Thank you @noi5e and also @Sagarpreet @pydevsg !!!

[jywarren]

Also noting, this is a good example of this happening - perhaps we shouldn't do count-based assertions because it causes interdependence among fixtures. While in some ways it's nice to see the code interdependencies, because it stops us from thinking too narrowly, it also creates barriers to code changes because changes cascade and affect other tested areas. Food for thought! Thanks again!

[codeclimate]

Code Climate has analyzed commit 97a6842 and detected 0 issues on this pull request.

View more on Code Climate.

[noi5e]

Just resolved the conflicts!

[jywarren]

Hooray!!