Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify bootstrap slider script and add defer tag #7939

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Minify bootstrap slider script and add defer tag #7939

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce925b
Minify bootstrap slider script and add defer tag
Tlazypanda May 21, 2020
bc1ee98
Merge branch 'main' into bootstrap-slider_min
jywarren Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/layouts/application.html.erb
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@

</style>

<script src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-slider/10.2.0/bootstrap-slider.js"></script>
<script defer src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-slider/10.2.0/bootstrap-slider.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, i'm just trying to think of where this is used so that it's clear it'll still work!

See how you can use the "blame" view to find out: https://github.com/publiclab/plots2/blame/master/app/views/layouts/application.html.erb#L95

Given it links here: #4633

Could you test that function to be sure, and just note that in this PR? That'll give us extra confidence! But this does look good to go!

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-slider/10.2.0/css/bootstrap-slider.min.css" />

</head>
Expand Down