Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text overflow in people page #7572

Merged
merged 1 commit into from Mar 2, 2020

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #7567
Fixed text username overflow in people page.
Before
Screenshot from 2020-02-28 17-03-23
After
Screenshot from 2020-02-28 17-03-46

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@Tlazypanda Tlazypanda requested a review from a team as a code owner February 28, 2020 11:36
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #7572 into master will increase coverage by 1.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7572      +/-   ##
==========================================
+ Coverage   80.07%   81.90%   +1.83%     
==========================================
  Files          97       97              
  Lines        5635     5615      -20     
==========================================
+ Hits         4512     4599      +87     
+ Misses       1123     1016     -107     
Impacted Files Coverage Δ
app/models/node.rb 90.90% <0.00%> (+0.37%) ⬆️
app/api/srch/search.rb 65.35% <0.00%> (+0.65%) ⬆️
app/controllers/users_controller.rb 82.29% <0.00%> (+1.04%) ⬆️
app/helpers/application_helper.rb 84.52% <0.00%> (+1.19%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/controllers/wiki_controller.rb 85.00% <0.00%> (+3.07%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+4.00%) ⬆️
app/controllers/tag_controller.rb 80.49% <0.00%> (+5.57%) ⬆️
app/controllers/questions_controller.rb 90.78% <0.00%> (+9.21%) ⬆️
... and 6 more

@Tlazypanda
Copy link
Collaborator Author

@VladimirMikulic @jywarren can you kindly review? Thanks ✌️

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @Tlazypanda Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7572-test_questions.png

7572-test_embeddable_grids.png

7572-test_signup.png

7572-test_viewing_the_settings_page.png

7572-test_tag_by_author_page.png

7572-failures_test_removing_tags_from_the_post.png

7572-test_wiki_page_with_inline_grids.png

7572-test_stats.png

7572-test_viewing_the_dashboard.png

7572-test_searching_an_item_from_the_homepage.png

7572-test_signup_modal_form_validation.png

7572-test_tag_stats.png

7572-test_login_modal_form_validation.png

7572-test_questions_shadow.png

7572-test_login_modal.png

7572-test_profile_page.png

7572-test_comments.png

7572-test_tags.png

7572-test_signup_modal.png

7572-test_wiki.png

7572-failures_test_viewing_the_dashboard.png

7572-test_methods.png

7572-failures_test_pages_tagged_with_place_get_a_full-width_map_across_the_top_of_the_page.png

7572-test_tag_page.png

7572-test_blog_page_with_location_modal.png

7572-test_tag_wildcard.png

7572-test_signup_modal_disabled_submit_button_on_empty_username.png

7572-test_embeddable_thumbnail_grids.png

7572-failures_test_pages_not_tagged_with_place_gets_a_side_map.png

7572-test_front_page_with_navbar_search_autocomplete.png

7572-test_spam_moderation_page.png

7572-test_login.png

7572-test_viewing_the_dropdown_menu.png

7572-test_viewing_question_post.png

7572-test_mobile_displays.png

7572-test_simple-data-grapher_powertag.png

7572-test_front.png

7572-test_question_page.png

7572-test_tag_contributors_page.png

7572-test_blog.png

7572-test_people.png

7572-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Tlazypanda 🚀

@Tlazypanda Tlazypanda closed this Feb 29, 2020
@Tlazypanda Tlazypanda reopened this Feb 29, 2020
@Tlazypanda
Copy link
Collaborator Author

@cesswairimu is this ready for a merge? 😅

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@cesswairimu cesswairimu merged commit 0c423c3 into publiclab:master Mar 2, 2020
icarito pushed a commit that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overflow in people page
4 participants