Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _events.html.erb #7559

Closed
wants to merge 1 commit into from
Closed

Update _events.html.erb #7559

wants to merge 1 commit into from

Conversation

micaelagimenez
Copy link

@micaelagimenez micaelagimenez commented Feb 24, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Feb 24, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #7559 into master will increase coverage by 1.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7559      +/-   ##
==========================================
+ Coverage   80.07%   82.03%   +1.95%     
==========================================
  Files          97       97              
  Lines        5635     5615      -20     
==========================================
+ Hits         4512     4606      +94     
+ Misses       1123     1009     -114
Impacted Files Coverage Δ
app/models/node.rb 90.9% <0%> (+0.37%) ⬆️
app/controllers/users_controller.rb 82.29% <0%> (+1.04%) ⬆️
app/helpers/application_helper.rb 84.52% <0%> (+1.19%) ⬆️
app/controllers/search_controller.rb 97.67% <0%> (+2.32%) ⬆️
app/controllers/wiki_controller.rb 85% <0%> (+3.07%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0%> (+3.39%) ⬆️
app/models/tag_selection.rb 96% <0%> (+4%) ⬆️
app/api/srch/search.rb 69.28% <0%> (+4.57%) ⬆️
app/services/execute_search.rb 94.44% <0%> (+5.55%) ⬆️
app/controllers/tag_controller.rb 80.49% <0%> (+5.57%) ⬆️
... and 7 more

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @micaelagimenez Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #
Screenshots 📸 (click to expand)

7559-test_questions.png

7559-test_embeddable_grids.png

7559-test_signup.png

7559-test_viewing_the_settings_page.png

7559-test_tag_by_author_page.png

7559-failures_test_removing_tags_from_the_post.png

7559-test_wiki_page_with_inline_grids.png

7559-test_stats.png

7559-test_viewing_the_dashboard.png

7559-test_searching_an_item_from_the_homepage.png

7559-test_signup_modal_form_validation.png

7559-test_tag_stats.png

7559-test_login_modal_form_validation.png

7559-test_questions_shadow.png

7559-test_login_modal.png

7559-test_profile_page.png

7559-test_comments.png

7559-test_tags.png

7559-test_signup_modal.png

7559-test_wiki.png

7559-test_methods.png

7559-test_tag_page.png

7559-test_blog_page_with_location_modal.png

7559-test_tag_wildcard.png

7559-test_signup_modal_disabled_submit_button_on_empty_username.png

7559-test_embeddable_thumbnail_grids.png

7559-test_front_page_with_navbar_search_autocomplete.png

7559-test_spam_moderation_page.png

7559-test_login.png

7559-test_viewing_the_dropdown_menu.png

7559-test_viewing_question_post.png

7559-test_mobile_displays.png

7559-test_simple-data-grapher_powertag.png

7559-test_front.png

7559-test_question_page.png

7559-test_tag_contributors_page.png

7559-test_blog.png

7559-test_people.png

7559-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@cesswairimu
Copy link
Collaborator

thanks so much for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@cesswairimu
Copy link
Collaborator

Hello @micaelagimenez , I am sorry but it seems like this was solved in another PR. Closing this...Let me know if you need help finding another issue. Thanks

@cesswairimu cesswairimu closed this Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants