Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the number of users for search #7554

Closed

Conversation

dburugupalli
Copy link
Contributor

@dburugupalli dburugupalli commented Feb 20, 2020

added the number of users for search

Fixes #7506 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

added the number of users for search
@welcome
Copy link

welcome bot commented Feb 20, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #7554 into master will decrease coverage by 7.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7554      +/-   ##
==========================================
- Coverage   82.02%   74.94%   -7.08%     
==========================================
  Files          97       97              
  Lines        5612     5735     +123     
==========================================
- Hits         4603     4298     -305     
- Misses       1009     1437     +428     
Impacted Files Coverage 螖
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) 猬囷笍
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) 猬囷笍
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) 猬囷笍
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) 猬囷笍
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) 猬囷笍
app/controllers/openid_controller.rb 0.00% <0.00%> (-53.85%) 猬囷笍
app/controllers/comment_controller.rb 72.34% <0.00%> (-14.90%) 猬囷笍
app/controllers/subscription_controller.rb 55.00% <0.00%> (-14.00%) 猬囷笍
app/controllers/users_controller.rb 69.12% <0.00%> (-12.99%) 猬囷笍
app/controllers/home_controller.rb 88.70% <0.00%> (-9.68%) 猬囷笍
... and 17 more

Showing number of results found in email search
@dburugupalli
Copy link
Contributor Author

@nstjean can you review the PR raised ?

app/views/admin/useremail.html.erb Outdated Show resolved Hide resolved
@dburugupalli
Copy link
Contributor Author

@nstjean i changed to regular parenthesis () and raised a PR. !

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!! 馃槃 馃帀

@dburugupalli
Copy link
Contributor Author

Great!!! smile tada

Thank You :)

@SidharthBansal
Copy link
Member

Kindly resolve the conflicts

@SidharthBansal
Copy link
Member

@dburugupalli thanks for your work.

@SidharthBansal
Copy link
Member

We will love to have your help on other issues. This issue seems to be already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing number of results found in email search
5 participants