Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:horizontal scroll for community projects in homepage #7550

Closed

Conversation

ayanchoudhary
Copy link
Member

@ayanchoudhary ayanchoudhary commented Feb 20, 2020

Fixes #7548

Screenshot from 2020-02-20 22-14-49

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Feb 20, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@ayanchoudhary
Copy link
Member Author

ayanchoudhary commented Feb 20, 2020

@publiclab/reviewers please review and help with the failing build.

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #7550 into master will decrease coverage by 1.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7550      +/-   ##
==========================================
- Coverage   81.87%   80.06%   -1.82%     
==========================================
  Files          97       97              
  Lines        5612     5632      +20     
==========================================
- Hits         4595     4509      -86     
- Misses       1017     1123     +106     
Impacted Files Coverage Δ
app/controllers/talk_controller.rb 100.00% <0.00%> (ø) ⬆️
app/mailers/password_reset_mailer.rb 100.00% <0.00%> (ø) ⬆️
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/drupal_content_field_mapper.rb 100.00% <0.00%> (ø) ⬆️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/drupal_content_field_map_editor.rb 100.00% <0.00%> (ø) ⬆️
app/controllers/home_controller.rb 98.38% <0.00%> (ø) ⬆️
app/controllers/search_controller.rb 95.34% <0.00%> (-2.33%) ⬇️
app/models/spamaway.rb 94.87% <0.00%> (ø) ⬆️
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
... and 49 more

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @ayanchoudhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #
Screenshots 📸 (click to expand)

7550-test_questions.png

7550-test_embeddable_grids.png

7550-test_signup.png

7550-test_viewing_the_settings_page.png

7550-test_tag_by_author_page.png

7550-test_wiki_page_with_inline_grids.png

7550-test_stats.png

7550-test_viewing_the_dashboard.png

7550-test_searching_an_item_from_the_homepage.png

7550-test_signup_modal_form_validation.png

7550-test_tag_stats.png

7550-test_login_modal_form_validation.png

7550-test_questions_shadow.png

7550-test_login_modal.png

7550-test_profile_page.png

7550-test_comments.png

7550-test_tags.png

7550-test_signup_modal.png

7550-test_wiki.png

7550-test_methods.png

7550-test_tag_page.png

7550-test_blog_page_with_location_modal.png

7550-test_tag_wildcard.png

7550-test_signup_modal_disabled_submit_button_on_empty_username.png

7550-test_embeddable_thumbnail_grids.png

7550-test_front_page_with_navbar_search_autocomplete.png

7550-test_spam_moderation_page.png

7550-test_login.png

7550-test_viewing_the_dropdown_menu.png

7550-test_viewing_question_post.png

7550-test_mobile_displays.png

7550-test_simple-data-grapher_powertag.png

7550-test_front.png

7550-test_question_page.png

7550-test_tag_contributors_page.png

7550-test_blog.png

7550-test_people.png

7550-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

@sssash18
Copy link
Contributor

@ayanchoudhary Please close and reopen the PR to restart travis as the failures are not related to your changes.Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Scroll on HomePage
3 participants