Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _related.html.erb #7541

Merged
merged 1 commit into from Apr 2, 2020
Merged

Update _related.html.erb #7541

merged 1 commit into from Apr 2, 2020

Conversation

priyanshbalyan
Copy link
Contributor

@priyanshbalyan priyanshbalyan commented Feb 19, 2020

Changed t to translation

Fixes #7538

Changed t to translation
@welcome
Copy link

welcome bot commented Feb 19, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@priyanshbalyan
Copy link
Contributor Author

priyanshbalyan commented Feb 19, 2020

@publiclab/reviewers Hopefully everything checks out!

Copy link
Contributor

@sssash18 sssash18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @priyanshbalyan ,but please it's my request to claim the issue first and then do it so that other community members are aware of it .

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #7541 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7541      +/-   ##
=========================================
+ Coverage   81.87%   81.9%   +0.02%     
=========================================
  Files          97      97              
  Lines        5612    5615       +3     
=========================================
+ Hits         4595    4599       +4     
+ Misses       1017    1016       -1
Impacted Files Coverage Δ
app/controllers/users_controller.rb 82.29% <100%> (+0.18%) ⬆️
app/services/execute_search.rb 88.88% <0%> (-5.56%) ⬇️
app/api/srch/search.rb 65.35% <0%> (-3.93%) ⬇️
app/controllers/wiki_controller.rb 85% <0%> (+3.07%) ⬆️

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @priyanshbalyan Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7541-test_questions.png

7541-test_embeddable_grids.png

7541-test_signup.png

7541-test_viewing_the_settings_page.png

7541-test_tag_by_author_page.png

7541-failures_test_removing_tags_from_the_post.png

7541-test_wiki_page_with_inline_grids.png

7541-test_stats.png

7541-test_viewing_the_dashboard.png

7541-test_searching_an_item_from_the_homepage.png

7541-test_signup_modal_form_validation.png

7541-test_tag_stats.png

7541-test_login_modal_form_validation.png

7541-test_questions_shadow.png

7541-test_login_modal.png

7541-test_profile_page.png

7541-test_comments.png

7541-test_tags.png

7541-test_signup_modal.png

7541-test_wiki.png

7541-test_methods.png

7541-test_tag_page.png

7541-test_blog_page_with_location_modal.png

7541-test_tag_wildcard.png

7541-test_signup_modal_disabled_submit_button_on_empty_username.png

7541-test_embeddable_thumbnail_grids.png

7541-test_front_page_with_navbar_search_autocomplete.png

7541-test_spam_moderation_page.png

7541-test_login.png

7541-test_viewing_the_dropdown_menu.png

7541-test_viewing_question_post.png

7541-test_mobile_displays.png

7541-test_simple-data-grapher_powertag.png

7541-test_front.png

7541-test_question_page.png

7541-test_tag_contributors_page.png

7541-test_blog.png

7541-test_people.png

7541-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@SidharthBansal
Copy link
Member

One test is failing. kindly fix it

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is failing. kindly fix it!

@sssash18
Copy link
Contributor

sssash18 commented Mar 9, 2020

@priyanshbalyan Please close and reopen the PR to restart travis

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@cesswairimu
Copy link
Collaborator

@SidharthBansal could you please review this again, its pending your requested changes to merge. Thanks

@SidharthBansal SidharthBansal merged commit 8148f85 into publiclab:master Apr 2, 2020
@welcome
Copy link

welcome bot commented Apr 2, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change t to translation in _related.html.erb
7 participants