Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text disappearance in small screen solved. #7539

Merged
merged 3 commits into from Mar 2, 2020

Conversation

NitinBhasneria
Copy link
Collaborator

@NitinBhasneria NitinBhasneria commented Feb 19, 2020

Fixes #7533 (<=== Add issue number here)

Screenshot from 2020-02-19 16-26-54
Screenshot from 2020-02-19 16-26-56

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #7539 into master will decrease coverage by 3.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7539      +/-   ##
==========================================
- Coverage   81.87%   78.14%   -3.74%     
==========================================
  Files          97       97              
  Lines        5612     5615       +3     
==========================================
- Hits         4595     4388     -207     
- Misses       1017     1227     +210
Impacted Files Coverage 螖
app/controllers/users_controller.rb 82.29% <100%> (+0.18%) 猬嗭笍
app/mailers/subscription_mailer.rb 49.01% <0%> (-45.1%) 猬囷笍
app/models/concerns/node_shared.rb 59.7% <0%> (-30.59%) 猬囷笍
app/mailers/admin_mailer.rb 69.56% <0%> (-30.44%) 猬囷笍
app/models/answer.rb 73.68% <0%> (-26.32%) 猬囷笍
app/mailers/comment_mailer.rb 74.28% <0%> (-25.72%) 猬囷笍
app/models/concerns/statistics.rb 88.52% <0%> (-8.2%) 猬囷笍
app/models/tag.rb 89.84% <0%> (-7.62%) 猬囷笍
app/models/node.rb 84.23% <0%> (-6.68%) 猬囷笍
app/models/answer_selection.rb 31.25% <0%> (-6.25%) 猬囷笍
... and 8 more

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your approach is to override the framework's class globally, which is highly discouraged. You've probably broken something else by using !important. Instead, you could've simply removed d-none classes from markup and the problem is solved.

@NitinBhasneria
Copy link
Collaborator Author

@VladimirMikulic ok thanks will surely do this.

@nstjean nstjean closed this Feb 19, 2020
@nstjean nstjean reopened this Feb 19, 2020
@nstjean
Copy link
Contributor

nstjean commented Feb 19, 2020

Great thanks for making those changes! Do you have a screenshot after changing it?

I restarted the tests. hopefully it passes!

@nstjean
Copy link
Contributor

nstjean commented Feb 19, 2020

The same test failed again. I'll take a look at it on my local later on.

@NitinBhasneria
Copy link
Collaborator Author

Ok, thanks @nstjean
here are the screenshots
Screenshot from 2020-02-19 20-43-36

Screenshot from 2020-02-19 20-43-38

@nstjean nstjean closed this Feb 21, 2020
@nstjean nstjean reopened this Feb 21, 2020
Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NitinBhasneria. Sorry for late review, this is great!

@NitinBhasneria
Copy link
Collaborator Author

@nstjean Do you know what this error is about?

@nstjean
Copy link
Contributor

nstjean commented Feb 24, 2020

No, I don't understand why that is failing :(

@cesswairimu cesswairimu reopened this Feb 25, 2020
@cesswairimu
Copy link
Collaborator

Restarting travis 馃槥

@NitinBhasneria
Copy link
Collaborator Author

@cesswairimu @nstjean All checks passed kindly see this.

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 馃帀 馃帀

@cesswairimu cesswairimu merged commit a29d1c6 into publiclab:master Mar 2, 2020
icarito pushed a commit that referenced this pull request Mar 31, 2020
* Text disappearance in small screen solved

* d-none class removed

* Error Removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No text appearing in mobile view.
4 participants