Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki edits to Wikis created #7536

Closed

Conversation

DouglasLutz
Copy link
Contributor

@DouglasLutz DouglasLutz commented Feb 18, 2020

Fixes #7515

Description

/profile/:username

The profile page was showing '? wiki edits' with wrong number and link to the user created wikis, changed the link to '? wikis created'.
after-profile-:username
Also did a refactor in the query.

/wikis/author/:username

Changed the query to get only the wiki pages created by the user.
after-wikis-author-:username
Still showing the number of research notes by the user (can be altered to show the number of wikis instead since it's in wikis page).

/notes/author/:username

Was also showing the wrong number of wiki edits, like profile page, removed the text from the page to show only the number of notes and match the page content.
after-notes-author-:username

From '? Wiki edits' to '? Wikis created'
Altered query to get only the nodes where type is 'page' which refers to wikis created by the user
@DouglasLutz DouglasLutz requested a review from a team as a code owner February 18, 2020 19:11
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8d2efcb). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7536   +/-   ##
=========================================
  Coverage          ?   80.06%           
=========================================
  Files             ?       97           
  Lines             ?     5634           
  Branches          ?        0           
=========================================
  Hits              ?     4511           
  Misses            ?     1123           
  Partials          ?        0
Impacted Files Coverage Δ
app/controllers/wiki_controller.rb 81.92% <ø> (ø)
app/controllers/users_controller.rb 81.18% <100%> (ø)

@SidharthBansal
Copy link
Member

Restarting travis

@SidharthBansal
Copy link
Member

There are some conflicts. Kindly remove them. Also write tests to ensure the correctness of proposed functionality

Thanks

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in wiki edit
2 participants