integrate At.js autocompletion into rich editor for tagnames and emoji #7526

keshav234156 · 2020-02-17T16:21:49Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome · 2020-02-17T16:21:51Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

keshav234156 · 2020-02-17T16:31:39Z

@jywarren @VladimirMikulic the instructions mentioned in https://github.com/publiclab/PublicLab.Editor#atwhojs-data-module didn't seem to integrate the autocomplete in pl.org.Any additional changes that you think are needed ?

codecov · 2020-02-17T16:32:23Z

Codecov Report

❗ No coverage uploaded for pull request base (main@4e52e2e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 96a8c78 differs from pull request most recent head 7363740. Consider uploading reports for the commit 7363740 to get more accurate results

@@           Coverage Diff           @@
##             main    #7526   +/-   ##
=======================================
  Coverage        ?   43.30%           
=======================================
  Files           ?       98           
  Lines           ?     6225           
  Branches        ?        0           
=======================================
  Hits            ?     2696           
  Misses          ?     3529           
  Partials        ?        0

keshav234156 · 2020-02-17T16:33:16Z

@niravasher

plotsbot · 2020-02-17T16:37:26Z

	1 Warning
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	4 Messages
📖	@keshav234156 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: `Fixes #123`.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖	#

Screenshots 📸 (click to expand)

7526-test_questions.png

7526-test_embeddable_grids.png

7526-test_signup.png

7526-test_viewing_the_settings_page.png

7526-test_tag_by_author_page.png

7526-test_wiki_page_with_inline_grids.png

7526-test_stats.png

7526-test_viewing_the_dashboard.png

7526-test_searching_an_item_from_the_homepage.png

7526-test_signup_modal_form_validation.png

7526-test_tag_stats.png

7526-test_login_modal_form_validation.png

7526-test_questions_shadow.png

7526-test_login_modal.png

7526-test_profile_page.png

7526-failures_test_posting_from_the_editor.png

7526-test_comments.png

7526-test_tags.png

7526-test_signup_modal.png

7526-test_wiki.png

7526-test_methods.png

7526-test_tag_page.png

7526-test_blog_page_with_location_modal.png

7526-test_tag_wildcard.png

7526-test_signup_modal_disabled_submit_button_on_empty_username.png

7526-test_embeddable_thumbnail_grids.png

7526-test_front_page_with_navbar_search_autocomplete.png

7526-test_spam_moderation_page.png

7526-test_login.png

7526-test_viewing_the_dropdown_menu.png

7526-test_viewing_question_post.png

7526-test_mobile_displays.png

7526-failures_test_main_textarea_image_drag_and_drop_upload.png

7526-test_simple-data-grapher_powertag.png

7526-test_front.png

7526-test_question_page.png

7526-test_tag_contributors_page.png

7526-test_blog.png

7526-failures_test_changing_and_reverting_versions_works_correctly_for_wiki.png

7526-test_people.png

7526-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

cesswairimu · 2020-09-18T19:42:12Z

Is this by any chance related to #8248 ? If so could we please align and maintain one PR. Thanks

cesswairimu · 2020-11-23T19:22:51Z

@sagarpreet-chadha could you please help with reviewing this. Thanks

gitpod-io · 2021-04-15T21:07:11Z

jywarren · 2021-04-15T21:07:22Z

Let's see how this does... i think we need to rebase?

jywarren · 2021-05-04T21:50:28Z

OK, i'm seeing:

===============[Screenshot]: tmp/screenshots/failures_test_post_note,_then_comment_on_FRESH_note.png
ERROR CommentTest#test_post_note,_then_comment_on_FRESH_note (523.75s)
Minitest::UnexpectedError:         ActionController::RoutingError: No route matches [GET] "/lib/publiclab-editor/data/emoji.js"
            /home/runner/work/plots2/plots2/vendor/bundle/ruby/2.6.0/gems/actionpack-5.2.3/lib/action_dispatch/middleware/debug_exceptions.rb:65:in `call'

2021-04-15 21:19:01 +0000 Rack app ("GET /lib/publiclab-editor/data/atwho.PLE.js" - (127.0.0.1)): #<ActionController::RoutingError: No route matches [GET] "/lib/publiclab-editor/data/atwho.PLE.js">
======[Screenshot]: tmp/screenshots/failures_test_posting_from_the_editor.png
ERROR PostTest#test_posting_from_the_editor (213.64s)
Minitest::UnexpectedError:         ActionController::RoutingError: No route matches [GET] "/lib/publiclab-editor/node_modules/at.js/dist/css/jquery.atwho.min.css"

So we're missing:

/lib/publiclab-editor/data/emoji.js
/lib/publiclab-editor/node_modules/at.js/dist/css/jquery.atwho.min.css

app/views/editor/rich.html.erb

gitpod-io · 2021-05-04T21:58:33Z

jywarren · 2021-05-04T21:58:47Z

Fixed some CSS and JS paths!!!

jywarren · 2021-05-04T22:21:08Z

Ooohhhhhh! Testing in GitPod!!

jywarren · 2021-05-04T22:42:06Z

Hmmmmm. OK this doesn't work in GitPod. I wonder if the option is getting set correctly?

https://github.com/publiclab/PublicLab.Editor/pull/48/files

codeclimate · 2021-05-04T23:19:18Z

Code Climate has analyzed commit 7363740 and detected 0 issues on this pull request.

View more on Code Climate.

jywarren · 2021-05-04T23:48:31Z

Woohoo!!!

jywarren · 2021-06-15T18:47:25Z

app/views/editor/rich.html.erb

+    $('.wk-wysiwyg')
+        .atwho(hashtags_config)
+        .atwho(emojis_config)
+        //.atwho(at_config) // off for performance reasons for now


@TildaDares here it is! This is where I turned off the username autocompletion. It uses the same API backend as your code. But the front-end implementation may be a little different as it's within a rich text editor!

* integrate editor n plots2 * Fixed relative paths to required JS and CSS files * tweaks/fixes * working; usernames off for performance Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>

integrate editor n plots2

6f68b42

keshav234156 requested a review from a team as a code owner February 17, 2020 16:21

jywarren changed the base branch from master to main June 30, 2020 18:06

cesswairimu closed this Nov 23, 2020

cesswairimu reopened this Nov 23, 2020

cesswairimu requested a review from sagarpreet-chadha November 23, 2020 19:21

Merge branch 'main' into editor-integration

a747164

jywarren reviewed May 4, 2021

View reviewed changes

app/views/editor/rich.html.erb Outdated Show resolved Hide resolved

jywarren reviewed May 4, 2021

View reviewed changes

app/views/editor/rich.html.erb Outdated Show resolved Hide resolved

jywarren reviewed May 4, 2021

View reviewed changes

app/views/editor/rich.html.erb Outdated Show resolved Hide resolved

jywarren reviewed May 4, 2021

View reviewed changes

app/views/editor/rich.html.erb Outdated Show resolved Hide resolved

Fixed relative paths to required JS and CSS files

e74c463

jywarren added 2 commits May 4, 2021 23:09

tweaks/fixes

0521064

working; usernames off for performance

7363740

jywarren merged commit 6233398 into publiclab:main May 4, 2021

jywarren changed the title ~~integrate editor n plots2~~ integrate At.js autocompletion into rich editor for tagnames and emoji May 11, 2021

jywarren reviewed Jun 15, 2021

View reviewed changes

integrate At.js autocompletion into rich editor for tagnames and emoji #7526

integrate At.js autocompletion into rich editor for tagnames and emoji #7526

Conversation

keshav234156 commented Feb 17, 2020

welcome bot commented Feb 17, 2020

keshav234156 commented Feb 17, 2020 • edited

codecov bot commented Feb 17, 2020 • edited

Codecov Report

keshav234156 commented Feb 17, 2020

plotsbot commented Feb 17, 2020

7526-test_questions.png

7526-test_embeddable_grids.png

7526-test_signup.png

7526-test_viewing_the_settings_page.png

7526-test_tag_by_author_page.png

7526-test_wiki_page_with_inline_grids.png

7526-test_stats.png

7526-test_viewing_the_dashboard.png

7526-test_searching_an_item_from_the_homepage.png

7526-test_signup_modal_form_validation.png

7526-test_tag_stats.png

7526-test_login_modal_form_validation.png

7526-test_questions_shadow.png

7526-test_login_modal.png

7526-test_profile_page.png

7526-failures_test_posting_from_the_editor.png

7526-test_comments.png

7526-test_tags.png

7526-test_signup_modal.png

7526-test_wiki.png

7526-test_methods.png

7526-test_tag_page.png

7526-test_blog_page_with_location_modal.png

7526-test_tag_wildcard.png

7526-test_signup_modal_disabled_submit_button_on_empty_username.png

7526-test_embeddable_thumbnail_grids.png

7526-test_front_page_with_navbar_search_autocomplete.png

7526-test_spam_moderation_page.png

7526-test_login.png

7526-test_viewing_the_dropdown_menu.png

7526-test_viewing_question_post.png

7526-test_mobile_displays.png

7526-failures_test_main_textarea_image_drag_and_drop_upload.png

7526-test_simple-data-grapher_powertag.png

7526-test_front.png

7526-test_question_page.png

7526-test_tag_contributors_page.png

7526-test_blog.png

7526-failures_test_changing_and_reverting_versions_works_correctly_for_wiki.png

7526-test_people.png

7526-test_wiki_revisions.png

cesswairimu commented Sep 18, 2020 • edited

cesswairimu commented Nov 23, 2020

gitpod-io bot commented Apr 15, 2021

jywarren commented Apr 15, 2021

jywarren commented May 4, 2021

gitpod-io bot commented May 4, 2021

jywarren commented May 4, 2021

jywarren commented May 4, 2021

jywarren commented May 4, 2021

codeclimate bot commented May 4, 2021

jywarren commented May 4, 2021

jywarren Jun 15, 2021

Choose a reason for hiding this comment

keshav234156 commented Feb 17, 2020 •

edited

codecov bot commented Feb 17, 2020 •

edited

cesswairimu commented Sep 18, 2020 •

edited