Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "translation" to necessary lines #7521

Merged
merged 1 commit into from Feb 24, 2020

Conversation

theOpetunde
Copy link
Contributor

@theOpetunde theOpetunde commented Feb 17, 2020

Update the index.html.erb file with the "translation" command at the necessary lines

Fixes #7494 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Update the index.html.erb file with the "translation" command at the necessary lines
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8d2efcb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7521   +/-   ##
=========================================
  Coverage          ?   81.87%           
=========================================
  Files             ?       97           
  Lines             ?     5612           
  Branches          ?        0           
=========================================
  Hits              ?     4595           
  Misses            ?     1017           
  Partials          ?        0

@sssash18
Copy link
Contributor

Great work @theOpetunde

@nstjean
Copy link
Contributor

nstjean commented Feb 17, 2020

Great, thanks for helping! Can you update the issue number? It's #7494 not 7490 :)

@theOpetunde
Copy link
Contributor Author

Great work @theOpetunde

Thank you very much @sssash18

@theOpetunde
Copy link
Contributor Author

Great, thanks for helping! Can you update the issue number? It's #7494 not 7490 :)

Oh.. Thank you very much. I have changed it now.

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@SidharthBansal SidharthBansal merged commit 4691cb7 into publiclab:master Feb 24, 2020
@jywarren
Copy link
Member

Thank you!!!

icarito pushed a commit that referenced this pull request Mar 31, 2020
Update the index.html.erb file with the "translation" command at the necessary lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change function t to translation in app/views/notes/index.html.erb
5 participants