Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_number buttons #7501

Merged
merged 3 commits into from Feb 21, 2020
Merged

page_number buttons #7501

merged 3 commits into from Feb 21, 2020

Conversation

keshavsethi
Copy link
Member

Fixes #7423
in /spam/wiki page number buttons are added and it looks like this.
Screenshot from 2020-02-15 20-51-43

Thanks!

@keshavsethi
Copy link
Member Author

@SidharthBansal @steviepubliclab @VladimirMikulic please review this
Thanks!!

@VladimirMikulic
Copy link
Contributor

The buttons should be centered.

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #7501 into master will decrease coverage by 26.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7501       +/-   ##
===========================================
- Coverage   81.87%   55.04%   -26.84%     
===========================================
  Files          97       97               
  Lines        5612     6973     +1361     
===========================================
- Hits         4595     3838      -757     
- Misses       1017     3135     +2118     
Impacted Files Coverage Δ
app/models/drupal_content_field_mapper.rb 100.00% <0.00%> (ø) ⬆️
app/models/drupal_content_field_map_editor.rb 100.00% <0.00%> (ø) ⬆️
app/controllers/features_controller.rb 80.70% <0.00%> (ø) ⬆️
app/controllers/search_controller.rb 30.50% <0.00%> (-67.17%) ⬇️
app/controllers/admin_controller.rb 14.88% <0.00%> (-63.18%) ⬇️
app/controllers/user_tags_controller.rb 21.48% <0.00%> (-62.80%) ⬇️
app/services/execute_search.rb 33.33% <0.00%> (-61.12%) ⬇️
app/controllers/questions_controller.rb 33.08% <0.00%> (-57.71%) ⬇️
app/controllers/home_controller.rb 45.80% <0.00%> (-52.59%) ⬇️
app/controllers/notes_controller.rb 31.40% <0.00%> (-52.00%) ⬇️
... and 31 more

@keshavsethi
Copy link
Member Author

@VladimirMikulic
Screenshot from 2020-02-16 01-41-55
Thanks!!

@nstjean
Copy link
Contributor

nstjean commented Feb 17, 2020

The buttons should be centered.

While I may agree that it looks better that way, all the other pages have the page numbers left-aligned. So we should stick with that for consistency across the site.

Notes:
FireShot Capture 286 - 🎈 Public Lab_ Research notes - publiclab org

Questions:
FireShot Capture 287 - 🎈 Public Lab_ Questions and Answers - publiclab org

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just remove the padding-left and then it will be good to go.

@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
2 Messages
📖 @keshavsethi Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 #
Screenshots 📸 (click to expand)

7501-test_questions.png

7501-test_embeddable_grids.png

7501-test_signup.png

7501-test_viewing_the_settings_page.png

7501-test_tag_by_author_page.png

7501-test_wiki_page_with_inline_grids.png

7501-test_stats.png

7501-test_viewing_the_dashboard.png

7501-test_searching_an_item_from_the_homepage.png

7501-test_signup_modal_form_validation.png

7501-test_tag_stats.png

7501-test_login_modal_form_validation.png

7501-test_questions_shadow.png

7501-test_login_modal.png

7501-test_profile_page.png

7501-test_comments.png

7501-test_tags.png

7501-test_signup_modal.png

7501-test_wiki.png

7501-test_methods.png

7501-test_tag_page.png

7501-test_blog_page_with_location_modal.png

7501-test_tag_wildcard.png

7501-test_signup_modal_disabled_submit_button_on_empty_username.png

7501-test_embeddable_thumbnail_grids.png

7501-test_front_page_with_navbar_search_autocomplete.png

7501-test_spam_moderation_page.png

7501-test_login.png

7501-test_viewing_the_dropdown_menu.png

7501-test_viewing_question_post.png

7501-test_mobile_displays.png

7501-test_simple-data-grapher_powertag.png

7501-test_front.png

7501-test_question_page.png

7501-test_tag_contributors_page.png

7501-test_blog.png

7501-test_people.png

7501-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

Copy link
Contributor

@nstjean nstjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@keshavsethi keshavsethi requested review from cesswairimu and removed request for cesswairimu February 19, 2020 21:11
@SidharthBansal SidharthBansal merged commit 885548a into publiclab:master Feb 21, 2020
@SidharthBansal
Copy link
Member

Well done!

@steviepubliclab
Copy link
Contributor

Thank you!

icarito pushed a commit that referenced this pull request Mar 31, 2020
* page-number

* center align

* padding removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get to page two on spam interface
7 participants