ADD: Missing system tests

[VladimirMikulic]

I've added the important system tests that were missing as a part of my last GCI task 🚀

Tests added:

• "adding a location to the wiki"
• "notification settings are working correctly"
• "subscribing to a tag"
• "unsubscribing from a tag"

Fixes #5316

@jywarren could you review this? Thanks.

[codecov]

Codecov Report

Merging #7322 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7322      +/-   ##
==========================================
+ Coverage   81.61%   81.86%   +0.24%     
==========================================
  Files          97       97              
  Lines        5602     5602              
==========================================
+ Hits         4572     4586      +14     
+ Misses       1030     1016      -14

Impacted Files	Coverage Δ
app/controllers/tag_controller.rb	80.31% <0%> (+0.31%)	⬆️
app/controllers/users_controller.rb	82.1% <0%> (+0.35%)	⬆️
app/controllers/subscription_controller.rb	69% <0%> (+12%)	⬆️

[SidharthBansal]

Maybe you are willing to work on more issues. Just I will say that we will not allow you to work till 30th January 2020 !!!
One week we expect you to take a break and enjoy. :-) 🚀
cc\ @Uzay-G @harshkhandeparkar

[Uzay-G]

From now until the 30th?

…

On Wed, Jan 22, 2020, 10:47 Sidharth Bansal ***@***.***> wrote: Maybe you are willing to work on more issues. Just I will say that we will not allow you to work till 30th January 2020 !!! One week we expect you to take a break and enjoy. :-) 🚀 cc\ @Uzay-G <https://github.com/Uzay-G> @harshkhandeparkar <https://github.com/HarshKhandeparkar> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7322?email_source=notifications&email_token=AMTREYMUJWOXJ7CGGCPAIN3Q7AIZXA5CNFSM4KJ6N77KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJS5DDI#issuecomment-577098125>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTREYIYUKNVWXUAWU2CG5LQ7AIZXANCNFSM4KJ6N77A> .

[SidharthBansal]

Gci students will be on off from 24 January 18 utc to 30 January so that they can relax

…

On Wed, 22 Jan 2020, 4:36 pm Vladimir Mikulic, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In yarn.lock <#7322 (comment)>: > @@ -18,6 +18,11 @@ esutils "^2.0.2" js-tokens "^4.0.0" ***@***.***/fontawesome-free@^5.12.0": No, I did not add this by mistake. We need it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7322?email_source=notifications&email_token=AFAAEQ5JHMZYRM5H6X2HCSDQ7ASCRA5CNFSM4KJ6N77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSTUIBQ#discussion_r369497300>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ4ANUCQLIBMMOSMSCLQ7ASCRANCNFSM4KJ6N77A> .

[SidharthBansal]

@Uzay-G kindly review. On Wed, 22 Jan 2020, 5:17 pm Sidharth Bansal, <bansal.sidharthcode@gmail.com> wrote:

…

Gci students will be on off from 24 January 18 utc to 30 January so that they can relax On Wed, 22 Jan 2020, 4:36 pm Vladimir Mikulic, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In yarn.lock > <#7322 (comment)>: > > > @@ -18,6 +18,11 @@ > esutils "^2.0.2" > js-tokens "^4.0.0" > > ***@***.***/fontawesome-free@^5.12.0": > > No, I did not add this by mistake. We need it. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#7322?email_source=notifications&email_token=AFAAEQ5JHMZYRM5H6X2HCSDQ7ASCRA5CNFSM4KJ6N77KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSTUIBQ#discussion_r369497300>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAAEQ4ANUCQLIBMMOSMSCLQ7ASCRANCNFSM4KJ6N77A> > . >

[Uzay-G]

I looked through the changes and it's good @SidharthBansal 👍