Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset password verification test #7302

Merged
merged 4 commits into from Jan 19, 2020

Conversation

sssash18
Copy link
Contributor

Fixes #5316 (<=== Add issue number here)
(part of)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #7302 into master will increase coverage by 18.97%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7302       +/-   ##
===========================================
+ Coverage   62.63%   81.61%   +18.97%     
===========================================
  Files          97       97               
  Lines        5669     5601       -68     
===========================================
+ Hits         3551     4571     +1020     
+ Misses       2118     1030     -1088
Impacted Files Coverage 螖
app/models/user.rb 91.05% <100%> (+1.98%) 猬嗭笍
app/controllers/home_controller.rb 98.38% <0%> (+1.61%) 猬嗭笍
app/models/comment.rb 76.95% <0%> (+2.48%) 猬嗭笍
app/models/node.rb 90.92% <0%> (+2.96%) 猬嗭笍
app/models/tag_selection.rb 96% <0%> (+4%) 猬嗭笍
app/controllers/stats_controller.rb 74.19% <0%> (+5.37%) 猬嗭笍
app/helpers/application_helper.rb 84.52% <0%> (+5.95%) 猬嗭笍
app/controllers/images_controller.rb 70.27% <0%> (+8.1%) 猬嗭笍
app/controllers/application_controller.rb 92.3% <0%> (+8.54%) 猬嗭笍
... and 27 more

@sssash18 sssash18 changed the title Reset pass test Reset password verification test Jan 19, 2020
@sssash18
Copy link
Contributor Author

sssash18 commented Jan 19, 2020

@SidharthBansal @jywarren Can you review the changes?

@SidharthBansal
Copy link
Member

@Uzay-G @VladimirMikulic kindly review

@SidharthBansal
Copy link
Member

Well done

@SidharthBansal SidharthBansal merged commit b80f193 into publiclab:master Jan 19, 2020
@sssash18 sssash18 deleted the reset_pass_test branch January 19, 2020 08:37
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Jan 21, 2020
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brainstorm a list of critical full-stack system tests we should add
2 participants