Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin for methods #5772

Merged
merged 1 commit into from May 29, 2019
Merged

Fix margin for methods #5772

merged 1 commit into from May 29, 2019

Conversation

CleverFool77
Copy link
Member

Fixes #5612

Screenshot from 2019-05-23 17-29-30

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77 CleverFool77 added review-me design issue requires more design work and discussion (i.e. mockups and sketches) labels May 23, 2019
@CleverFool77 CleverFool77 mentioned this pull request May 27, 2019
Closed
@jywarren jywarren merged commit cfb0326 into publiclab:master May 29, 2019
@jywarren
Copy link
Member

Nice!!!

@CleverFool77 CleverFool77 deleted the method-margin-mobile branch June 28, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siaw23-retired siaw23-retired siaw23-retired approved these changes

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) review-me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect and solve Bootstrap 4 follow-up fixes
3 participants
@CleverFool77 @jywarren @siaw23-retired