Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sidebar Share your button dropdown-menu position with bootstrap4 #5755

Merged
merged 1 commit into from May 21, 2019

Conversation

CleverFool77
Copy link
Member

Fixes #5612

Screenshot from 2019-05-21 17-37-41

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77 CleverFool77 added design issue requires more design work and discussion (i.e. mockups and sketches) upgarde-bootstrap4 labels May 21, 2019
@plotsbot
Copy link
Collaborator

plotsbot commented May 21, 2019

2 Messages
📖 @CleverFool77 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue requires more design work and discussion (i.e. mockups and sketches)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect and solve Bootstrap 4 follow-up fixes
3 participants