Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the user signup page #5704

Merged
merged 3 commits into from May 10, 2019
Merged

Conversation

Souravirus
Copy link
Member

Fixes #5612 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Souravirus
Copy link
Member Author

Hi @jywarren, I corrected the signup page. Now it's looking like this:
image
image
See if it's fine. Thank you!!

@jywarren
Copy link
Member

jywarren commented May 10, 2019 via email

@jywarren
Copy link
Member

jywarren commented May 10, 2019 via email

@plotsbot
Copy link
Collaborator

plotsbot commented May 10, 2019

2 Messages
📖 @Souravirus Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Ill see if I can work on the animals

@jywarren
Copy link
Member

Thanks!!

@Souravirus
Copy link
Member Author

Excluding the animals, everything is correct, right?

@Souravirus
Copy link
Member Author

Yeah, it worked. Here is the screenshot
image

@jywarren
Copy link
Member

Awesome. I'm suggestinge a few changes too, hang on...

@jywarren
Copy link
Member

Cool, see the changes I just pushed! I think we're good to go now!

@Souravirus
Copy link
Member Author

Ok Checking.

@Souravirus
Copy link
Member Author

Yeah looks good to me.

@jywarren
Copy link
Member

🎉

@jywarren jywarren merged commit fe2ffd6 into publiclab:master May 10, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
* Corrected the user signup page

* Corrected the animals in the verification state of the signup

* Update _create_form.html.erb
digitaldina added a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
digitaldina added a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect and solve Bootstrap 4 follow-up fixes
3 participants