New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the user signup page #5704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jywarren, I corrected the signup page. Now it's looking like this: |
Oh, can you actually compare to publiclab.org/signup?
…On Fri, May 10, 2019, 2:51 PM Sourav Sahoo ***@***.***> wrote:
Hi @jywarren <https://github.com/jywarren>, I corrected the signup page.
Now it's looking like this:
[image: image]
<https://user-images.githubusercontent.com/17192149/57549937-7fe27100-7382-11e9-9228-bc27a1c6b9df.png>
[image: image]
<https://user-images.githubusercontent.com/17192149/57549953-883aac00-7382-11e9-9cc1-3185322810fa.png>
See if it's fine. Thank you!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5704 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JYHR3BZCWBSC4GDKKTPUW7YHANCNFSM4HMFNV7Q>
.
|
It's close but not quite there. We're planning to publish to the live site
today!!!
…On Fri, May 10, 2019, 2:56 PM Jeffrey Warren ***@***.***> wrote:
Oh, can you actually compare to publiclab.org/signup?
On Fri, May 10, 2019, 2:51 PM Sourav Sahoo ***@***.***>
wrote:
> Hi @jywarren <https://github.com/jywarren>, I corrected the signup page.
> Now it's looking like this:
> [image: image]
> <https://user-images.githubusercontent.com/17192149/57549937-7fe27100-7382-11e9-9228-bc27a1c6b9df.png>
> [image: image]
> <https://user-images.githubusercontent.com/17192149/57549953-883aac00-7382-11e9-9cc1-3185322810fa.png>
> See if it's fine. Thank you!!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#5704 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAF6JYHR3BZCWBSC4GDKKTPUW7YHANCNFSM4HMFNV7Q>
> .
>
|
Generated by 🚫 Danger |
Ill see if I can work on the animals |
Thanks!! |
Excluding the animals, everything is correct, right? |
Awesome. I'm suggestinge a few changes too, hang on... |
Cool, see the changes I just pushed! I think we're good to go now! |
Ok Checking. |
Yeah looks good to me. |
🎉 |
digitaldina
pushed a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
* Corrected the user signup page * Corrected the animals in the verification state of the signup * Update _create_form.html.erb
digitaldina
added a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
This reverts commit 3fd4e8f.
digitaldina
added a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
This reverts commit 3fd4e8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5612 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!