Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweaks to comment options #5700

Merged
merged 1 commit into from May 9, 2019
Merged

tweaks to comment options #5700

merged 1 commit into from May 9, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented May 9, 2019

@plotsbot
Copy link
Collaborator

plotsbot commented May 9, 2019 •
edited

1 Message
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member Author

jywarren commented May 9, 2019 

 FAIL["test_viewing_the_dashboard", #<Minitest::Reporters::Suite:0x00005594c1bccb30 @name="DashboardTest">, 267.84634400999994]
 test_viewing_the_dashboard#DashboardTest (267.85s)
        expected to find visible css ".row.header > h1" with text "Dashboard" but there were no matches. Also found "Community research", which matched the selector but not all filters. 
        test/system/dashboard_test.rb:19:in `block in <class:DashboardTest>'

@jywarren jywarren merged commit f044a99 into master May 9, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
@jywarren @digitaldina
tweaks to comment options (publiclab#5700)
3e51910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jywarren @plotsbot