Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag search results for maps #5659

Merged
merged 1 commit into from May 9, 2019

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented May 5, 2019

Fixes #5658
(<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Screenshot of update:
Screen Shot 2019-05-05 at 5 40 53 AM

@sashadev-sky sashadev-sky changed the title Add to config/locales file Fix tag search results for maps May 5, 2019
@sashadev-sky
Copy link
Member Author

@publiclab/reviewers

@sashadev-sky
Copy link
Member Author

sashadev-sky commented May 5, 2019

It looks like the link to the word "here" (/maps) is broken due to:

uninitialized constant WillPaginate::ActionView::BootstrapLinkRenderer

--- Update: fixed this by clearing the cache

@sashadev-sky sashadev-sky added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label May 5, 2019
@plotsbot
Copy link
Collaborator

plotsbot commented May 5, 2019

2 Messages
📖 @sashadev-sky Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@sashadev-sky
Copy link
Member Author

@jywarren any idea why this is failing at post_test.rb? I'm not sure it has to do with my code and I saw you recently added that testing file

@jywarren
Copy link
Member

jywarren commented May 7, 2019

Trying to fix a system test in #5661 - now we've resolved it, this may need a rebase? Thanks!

@sashadev-sky
Copy link
Member Author

The test passed after rebase! thank you @jywarren

@jywarren jywarren merged commit 59a0773 into publiclab:master May 9, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag variable is missing from search input
4 participants