Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5520: Fixed comment editing section. #5628

Merged

Conversation

valeriacobian
Copy link
Contributor

@valeriacobian valeriacobian commented Apr 26, 2019

Fixes #5520

PR5520

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

1 Message
📖 @ValeriaCobianISW Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren jywarren merged commit d059521 into publiclab:master Apr 26, 2019
@jywarren
Copy link
Member

This looks great. Thanks a million for fixing this!!! You did a great job!!! And thanks for the gif 👍 🙌

We should create a system test to protect this functionality! #5316

Kind of like this one: #5605

Would you have any interest in trying to write a system test to prevent this from breaking in the future?

Thanks again!!! 🎉 🎉

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment Editing Seems Broken
3 participants