Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fixes to bootstrap 4 upgrade #5613

Merged
merged 3 commits into from Apr 30, 2019
Merged

Follow up fixes to bootstrap 4 upgrade #5613

merged 3 commits into from Apr 30, 2019

Conversation

Souravirus
Copy link
Member

@Souravirus Souravirus commented Apr 24, 2019 •
edited

Fixes #5612 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • [] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

plotsbot commented Apr 24, 2019 •
edited

2 Messages
📖 @Souravirus Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@Souravirus Souravirus changed the title Corrected some missing bootstrap classes in editor toolbar Follow up fixes to bootstrap 4 upgrade Apr 26, 2019
@Souravirus Souravirus mentioned this pull request Apr 26, 2019
Closed
@jywarren
Copy link
Member

Is this ready to merge? Thank you @Souravirus and hope your exams are going well!!!! 🎉

@Souravirus
Copy link
Member Author

Yes it is @jywarren.

@jywarren jywarren merged commit 8e0cb64 into publiclab:master Apr 30, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@Souravirus @jywarren
Follow up fixes to bootstrap 4 upgrade (publiclab#5613)
578e681 
* Corrected some missing bootstrap classes in editor toolbar

* Some changes with the file inputs in the rich editor page

* Added logout button to the profile button
digitaldina pushed a commit to digitaldina/plots2 that referenced this pull request May 12, 2019
@Souravirus @digitaldina
Follow up fixes to bootstrap 4 upgrade (publiclab#5613)
e18c409 
* Corrected some missing bootstrap classes in editor toolbar

* Some changes with the file inputs in the rich editor page

* Added logout button to the profile button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect and solve Bootstrap 4 follow-up fixes
3 participants
@Souravirus @plotsbot @jywarren